Closed khad closed 2 years ago
@khad thank you, I agree. @rcoletti116 would you like to update, and set a default in the schema and in the code?
I'll take a look and think about this one. I had this in the positive before submitting the PR, but there was a reason I changed it.
Some other possibilities if you want to preserve the current true/false states:
Pause when turned off
Pause when switch is off
Pause when powered off
Pause when switch is powered off
I don't personally like "powered off", but it's the language Apple uses in the UI.
(I wouldn't recommend "Pause when stopped" because it seems like a logical contradiction. Pause and stop are two different things, no?)
I've got a PR coming that should reverse this and make it more logical. As far as pause vs. stop - they are two different things to Roomba, though iRobot's own app has tried to do away with stop. Stop ends a cleaning job and pause does not.
The next version will be "Dock when stopped," with the default being "true" to preserve the current function for all users who update.
Settings should be stated in the positive for clarity.
Expected Behavior
The last setting in the screenshot should be:
It can default to on/"true".
Current Behavior
The current setting is a double negative when it is in its default state, which makes it harder to understand at a glance:
Or, in the config:
Versions