search

homebridge-plugins / homebridge-roomba2

Homebridge plugin to connect iRobot Roomba devices with Homebridge/HomeKit.
MIT License
143 stars 17 forks source link

noDockOnStop -> DockOnStop #74

Closed rcoletti116 closed 2 years ago

rcoletti116 commented 2 years ago

Changes: config.schema.json accessory.ts ReadMe

Update Config option to DockOnStop, where 'true' means the robot will return home to it's dock when the HomeKit accessory is powered off/stopped.

The default value is set to 'true' so that the current expected behavior does not change for all users.

karlvr commented 2 years ago

@rcoletti116 thank you, I hope you don't mind the constant change requests. I'm keen to make everything perfect!

karlvr commented 2 years ago

@rcoletti116 it's weird eh. I'll do a manual merge on it.

karlvr commented 2 years ago

@rcoletti116 OK, I rebased your PR, it ended up being a lot of messy commits so I squashed it up. I think the issue is that you're making the PR from a working branch. I reckon remove your branches, and always grab a fresh branch from this repository's main branch and build your PR from that, that will avoid the odd issues.

So this was actually merged in 2863a494d40ee2ce9bb047a34e04dd0b1c182c67

karlvr commented 2 years ago

Released in v1.3.0-beta.7