homebridge-plugins / homebridge-roomba2

Homebridge plugin to connect iRobot Roomba devices with Homebridge/HomeKit.
MIT License
146 stars 17 forks source link

Finish Identify Characteristic #77

Closed rcoletti116 closed 2 years ago

rcoletti116 commented 3 years ago

Changes:

Apple's Home app doesn't regularly expose the identify feature, but most 3rd party apps (Eve, Controller, Home+) do. Triggering 'Identify' will send a find command to the roomba, which will then beep various tones and pulse its status lights. This is ideal for finding when it has been stopped or stuck under a bed or similar.

karlvr commented 2 years ago

@rcoletti116 sorry this took me so long; the whitespace issues weren't resolved in this PR... you can see on the Files Changed tab. Also the changes weren't type safe, it appears; the identify() method doesn't support a call-back? I've remedied and merged in c1f6a6f1e5f3c847e06a5796e3618f06736ebbfe. Thanks for contributing this. I can't test it, but it looks like it should work the same as your branch!