homebridge-plugins / homebridge-roomba2

Homebridge plugin to connect iRobot Roomba devices with Homebridge/HomeKit.
MIT License
144 stars 17 forks source link

Feature request: invoke favorite job #9

Open i3laze opened 3 years ago

i3laze commented 3 years ago

First of all, thank you for picking up the flag! The stv plugin had to be polished for years.

As official iRobot app totally lacks Siri Shortcuts commands I humbly ask you to try and implement switch accessories for each favorite job stored in the Roomba profile. Recently introduced “clean zones” feature made these jobs even more focused.

This way we could simply ask Siri to “Clean the kitchen” or “clean the mat (at the front door)”.

pablonosh commented 3 years ago

+1

pablonosh commented 3 years ago

ok step one is to get the regions from the state

https://github.com/koalazak/dorita980#getRobotState

and pass to https://github.com/koalazak/dorita980#cleanRoom

iRayanKhan commented 3 years ago

I haven't been able to test this, since I don't have the feature. My app keeps saying "coming soon". I can try to make a dodgy implementation, but no guarantees it will work. Do any of y'all have discord?

gloaysa commented 3 years ago

Hi, I do and would be happy to help :)

Edit: I just sent you an email

i3laze commented 3 years ago

I haven't been able to test this, since I don't have the feature. My app keeps saying "coming soon". I can try to make a dodgy implementation, but no guarantees it will work. Do any of y'all have discord?

I believe specific room cleaning would be enough. Clean zones are probably just a sub-array of Favorites: 2BEE2E37-2EF4-4D6A-98C0-5DE058E4798A

iRayanKhan commented 3 years ago

Looking to get this added in the release after todays. There currently is a way to get it to do rooms, but I can't test it as my app (up to date) still says it's coming soon.

The main hurdle is that the plugin is an accessory, not a platform. Meaning the way to get this to work is wonky. If anyone is willing to make a PR that converts this a platform I will be grateful. I will eventually convert this plugin into a platform, I just don't have the time right now. In the mean time, this weekend I may have a beta to test room cleaning.

Please add my discord if you are interested in beta testing this feature, and tell me when you add me you're from GitHub so ik.

Disc: iRayanKhan#9697

It is case-sensitive.

i3laze commented 3 years ago

Thanks for your eagerness. iRobot is at remote location, so I can’t participate in beta - sorry. Anyone else, guys?

Clean zones for i7 were released for Russia in September, 4+ months after US. May be you’ll have it some day too.

whreams commented 3 years ago

I’m in to beta test.

On Dec 3, 2020, at 9:21 AM, Rayan Khan notifications@github.com wrote:

Looking to get this added in the release after todays. There currently is a way to get it to do rooms, but I can't test it as my app (up to date) still says it's coming soon.

The main hurdle is that the plugin is an accessory, not a platform. Meaning the way to get this to work is wonky. If anyone is willing to make a PR that converts this a platform I will be grateful. I will eventually convert this plugin into a platform, I just don't have the time right now. In the mean time, this weekend I may have a beta to test room cleaning.

Please add my discord if you are interested in beta testing this feature, and tell me when you add me you're from GitHub so ik.

Disc: iRayanKhan#9697

It is case-sensitive.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/iRayanKhan/homebridge-roomba2/issues/9#issuecomment-738074482, or unsubscribe https://github.com/notifications/unsubscribe-auth/APK2HVUEYFOISOBEO2W5DJDSS6UIPANCNFSM4TOD74DA.

iRayanKhan commented 3 years ago

Clean zones for i7 were released for Russia in September, 4+ months after US. May be you’ll have it some day too.

Funny thing is, I'm in the US. I don't ever use the app since I use it in HomeKit, but I'll check tonight, and see if I got the update.

gloaysa commented 3 years ago

I'll also have time the coming week

Pblondin123 commented 3 years ago

+1 am in to participate in testing this as well

bloomkd46 commented 3 years ago

Here's a link for how other people did room by room cleaning for different roomba's https://www.npmjs.com/package/homebridge-xiaomi-roborock-vacuum

whreams commented 3 years ago

+1

Pblondin123 commented 3 years ago

hi, any news on this one ? am starting to realize that i never request a full floor clean, i pre program favorites, so this feature would be really great.

brettstah commented 3 years ago

I just picked up an i8+ to upgrade from an older model that doesn't support room by room cleaning, so suddenly I am very interested in this functionality too.

LucasCostaAtCyberSaint commented 3 years ago

I understand this request is asking for favorite jobs. I would like to start cleaning specific rooms. Should I create a separate ticket request for that?

i3laze commented 3 years ago

I understand this request is asking for favorite jobs. I would like to start cleaning specific rooms. Should I create a separate ticket request for that?

Nope, this one is exactly about the room and spot cleaning. Any updates are welcome.

sudoischenny commented 3 years ago

A solution for everyone is to get assistant relay and HTTP switches for homebridge. Use the HTTP switch to invoke google assistant commands to the relay which can tell Roomba where to clean.

dben110 commented 3 years ago

+1 on this. Happy to help in any testing

soelu commented 3 years ago

Would really like to see this happen. We use this feature every time after dinner to clean up the area around the dining table.

redeemer666 commented 2 years ago

+1 also for me. Must be very nice to have a “switch” for every favorites saved in robots, if that’s is possible of course

jostrasser commented 2 years ago

Must be very nice to have a “switch” for every favorites saved in robots, if that’s is possible of course

+1 on this feature...

Good idea from @redeemer666 if this is possible. Every "Roomba Job" or "Clean Zone" should get a separate switch to be able to control it via HomeKit.

karlvr commented 2 years ago

@jostrasser I think the only real impediment to adding multiple switches is what it looks like in the UI in HomeKit... but maybe it works AOK with Siri and that's all that's needed? The latest beta has added an extra Docking switch. Have you see that? If that switch was to trigger a favourite job instead, would it serve this purpose?

jostrasser commented 2 years ago

@karlvr thanks for your feedback. No, I didn't saw this yet, because I am pretty new here and I am starting right now with the plugin for homebridge. I saw this thread while looking around ;) Regarding the new beta: The goal should be to create a separate switch for each room which is defined on Roomba´s Clean Map, Cleaning Zones are also defined on the Clean Map. One possibility will be to save each defined Room or Cleaning Zone as "Favorite". Then your recommendation should work I think. I have to test this ;) I have no idea if it is difficult to get a possibility for configuring "rooms" and "cleaning zones" directly as switch. Using the Favourites function in the App will make this Feature unusable for other users of the App because ALL rooms and Cleaning Zones are favourized. So there is no benefit anymore ;)

redeemer666 commented 2 years ago

Hi @karlvr

Yeah I think the same setup as the “docking switch” it should be functional for trigging the favorites jobs saved in the app. Also the “rooms” switch, requested by @jostrasser , can be a neat idea, but it should be checked out how the robot behave when you start cleaning a room and change to another when is still cleaning.

kylecwhite commented 2 years ago

I second this. I would love the ability to perform a targeted clean via HomeKit. This could be a room, area or as others have suggested favourite jobs. This would make it much more useful. Awesome work, love the plugin.

ThatGirl0903 commented 2 years ago

Chiming in to say I agree; would absolutely love to see clean the ability to use either favorites or clean by room in HomeKit automations.

i3laze commented 2 years ago

At last I’ve purchased an i7 for myself. I’m eager to test anything.

franciswernet commented 2 years ago

Any update on this feature?

jostrasser commented 2 years ago

@jostrasser I think the only real impediment to adding multiple switches is what it looks like in the UI in HomeKit... but maybe it works AOK with Siri and that's all that's needed? The latest beta has added an extra Docking switch. Have you see that? If that switch was to trigger a favourite job instead, would it serve this purpose?

@karlvr any updates on this feature request? A switch that triggers targeted room cleaning (rooms defined in the iRobot app) would be sufficient for most of us, but I have no idea how difficult it is to implement. Also mentioned by @i3laze: https://github.com/karlvr/homebridge-roomba2/issues/9#issuecomment-724452683

enoughtobreakthings commented 2 years ago

Dropping in to say I don’t mind having a bunch of switches for each Favorite job I’ve saved or individual rooms. I can create a separate Home room that contains all of the Favorite Roomba Jobs or Rooms, and you can hide each tile individually from cluttering the default Home/Favorites panel.

jhaleit commented 2 years ago

Just a suggestion... instead of having a switch for each room why not use a multi switch and let us type in the rooms we want?

Is there a way to check the status for which room the Roomba is in?

jhaleit commented 2 years ago

Example

This is the alarm for the eufy plugin. It's a multi switch.

bloomkd46 commented 2 years ago

If you are interested, I have added room-by-room support in the homebridge-iRobot plug-in

bloomkd46 commented 2 years ago

https://i.redd.it/lssgb08kdgn41.jpg

That is not possible for this because that is a security system. The only option is multiple switches. In the homebridge-iRobot plug-in I tried to do an app chooser like you would do on a tv, however it requires the accessory to be on to change the “app”

jhaleit commented 2 years ago

https://i.redd.it/lssgb08kdgn41.jpg

That is not possible for this because that is a security system. The only option is multiple switches. In the homebridge-iRobot plug-in I tried to do an app chooser like you would do on a tv, however it requires the accessory to be on to change the “app”

This feature seems broken for the S9+.. When I send the Roomba to clean a room and then go to the HomeKit to rename the switch it displays in red "Not responding".. The power button switch seems to turn on to clean everything or turn off to go home..

Homekitdude commented 2 years ago

So anyway to get specific room support for Siri yet or nah? So bummed this isn’t baked in already.

jostrasser commented 2 years ago

Some news about native integration: https://investor.irobot.com/news-releases/news-release-details/irobot-releases-genius-40-home-intelligence-doubles-intelligence

i3laze commented 2 years ago

iRobot.App update v6.4 is out. Unfortunately, it did introduce just basic Siri commands: Stop, Resume, Dock, Clear everything.

Topic feature request stands.

ccwillia commented 2 years ago

Any updates? I have been focused on just vacuuming my carpeted areas so it would be great if i could trigger that instead of clean everywhere

mrfatboy commented 1 year ago

Any updates? I really would like to put this into Homekit.