search

homebridge-plugins / homebridge-roomba2

Homebridge plugin to connect iRobot Roomba devices with Homebridge/HomeKit.
MIT License
146 stars 17 forks source link

Add ability to disable verbose logging #97

Closed adammodlin closed 2 years ago

adammodlin commented 2 years ago

This plugin is spamming my HomeBridge logs, would love for a way to disable it. @karlvr - any objections if I add a config setting to disable verbose logging? If not, I'll submit a PR.

adammodlin commented 2 years ago

Looks to be very simple - debug variable is hardcoded to true.

adammodlin commented 2 years ago

Added PR #98 .

brianleesmith commented 2 years ago

I see the PR but I'm guessing this hasn't been worked into the beta yet? Really want to use the beta all the time for my j7+, but the logs are basically unusable with debug on all the time. :(

redeemer666 commented 2 years ago

Same here, why don’t you add it as a config.json variable instead of hard coding it? I have to use the latest beta since 1.2.2 is not working for my 2 robots but the homebridge log is spammed with debug messages…

adammodlin commented 2 years ago

I have a PR (linked above)...but no acknowledgement.

karlvr commented 2 years ago

Resolved by #98 thanks @adammodlin