search

homebridge / HAP-NodeJS

Node.js implementation of the HomeKit Accessory Protocol (HAP)
Apache License 2.0
2.69k stars 630 forks source link

provide connection source address hint to advise udp binding #1022

Closed koush closed 8 months ago

koush commented 9 months ago

Currently HAP-NodeJS doesn't provide the incoming address for the HAP connection. This means that the UDP video must bind to 0.0.0.0, and can be problematic. For example, wifi and ethernet may both be connected to the LAN. Binding to all addresses and sending data may result in the video being sent over wifi.

Currently getting around this by requiring users to select their LAN IP addresses, and guessing which address to use based on ipv4 and ipv6. This doesn't really work if multiple ipv4 addresses are advertised on different networks.

Providing the source address for the connection in addition to the target would be ideal here.

DragonWork commented 8 months ago

So this fairly minor but effective PR is dangling for a month because two (deprecated node v14 and v16) checks are blocking the merging? Can someone manually merge please?