Closed Shaquu closed 4 months ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
src/BridgedCore.ts | 0 | 4 | 0.0% | ||
src/Core.ts | 0 | 4 | 0.0% | ||
<!-- | Total: | 0 | 8 | 0.0% | --> |
Totals | |
---|---|
Change from base Build 9655031976: | 0.005% |
Covered Lines: | 7414 |
Relevant Lines: | 10615 |
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
src/BridgedCore.ts | 0 | 4 | 0.0% | ||
src/Core.ts | 0 | 4 | 0.0% | ||
<!-- | Total: | 0 | 8 | 0.0% | --> |
Totals | |
---|---|
Change from base Build 9655031976: | 0.005% |
Covered Lines: | 7414 |
Relevant Lines: | 10615 |
couple of comments.
i will always veer towards asking if any of the changes you have made could potentially breaking in any way
One potential break. I removed 💦
from Accessory and Service.
It was used in AccessoryInformation
Characteristic.
But from what I see it was not used to generate UUID.
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
src/BridgedCore.ts | 0 | 4 | 0.0% | ||
src/Core.ts | 0 | 4 | 0.0% | ||
<!-- | Total: | 0 | 8 | 0.0% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
src/lib/Accessory.ts | 3 | 89.29% | ||
<!-- | Total: | 3 | --> |
Totals | |
---|---|
Change from base Build 9655031976: | -0.07% |
Covered Lines: | 7411 |
Relevant Lines: | 10615 |
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
src/BridgedCore.ts | 0 | 4 | 0.0% | ||
src/Core.ts | 0 | 4 | 0.0% | ||
<!-- | Total: | 0 | 8 | 0.0% | --> |
Totals | |
---|---|
Change from base Build 9673726680: | 0.005% |
Covered Lines: | 7411 |
Relevant Lines: | 10615 |
Ready to be merged?
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
src/BridgedCore.ts | 0 | 4 | 0.0% | ||
src/Core.ts | 0 | 4 | 0.0% | ||
<!-- | Total: | 0 | 8 | 0.0% | --> |
Totals | |
---|---|
Change from base Build 9690647033: | 0.08% |
Covered Lines: | 7414 |
Relevant Lines: | 10615 |
:recycle: Current situation
Describe the current situation. Explain current problems, if there are any. Be as descriptive as possible (e.g., including examples or code snippets).
:bulb: Proposed solution
Describe the proposed solution and changes. How does it affect the project? How does it affect the internal structure (e.g., refactorings)?