search

homebridge / HAP-NodeJS

Node.js implementation of the HomeKit Accessory Protocol (HAP)
Apache License 2.0
2.68k stars 630 forks source link

Suggestion: Bump to 1.0 #676

Closed hobbyquaker closed 2 months ago

hobbyquaker commented 5 years ago

Hi! I'm maintaining two projects that depend on HAP-Nodejs, both have quite a bunch of users that are using them since years "in production". As HAP-Nodejs can be considered stable for a long time now I suggest to bump the Version to 1.0. Would have some advantages: You could fully utilize the semantic versioning scheme, patch only for bugfixes, minor for compatible changes/features, major for breaking changes. With the current 0.x scheme this is not possible, patch is bumped for features, changes and bugfixes and the role of the minor is unclear. For me as a maintainer of packages depending on HAP-Nodejs it would be much easier to specify a proper version range in the package.json - and last but not least: I see no reason for not doing it :-) @KhaosT what do you think? Regards, Sebastian

Shaquu commented 5 years ago

+1 for semantic versioning I have the same situation here

hassankhan commented 5 years ago

Here's a list of things I'd like to see before v1:

Obviously all of them may not be realistic, but I'd love to hear other contributors' thoughts

Apollon77 commented 5 years ago

Why break nodejs 8 before it is eol? Or wait till next April. ;-) What benefit would it have to only support node 10+?

hobbyquaker commented 5 years ago

@hassankhan Sounds legit :)

Create integration test suite using hap-client Set up CI/CD process

I can offer my help regarding integration tests and travis setup, I think we could reuse a lot of the testing setup of https://github.com/hobbyquaker/homekit2mqtt

Why break nodejs 8 before it is eol?

I would also suggest to support all versions as long as they are in maintenance, so for Node 8 until December 2019:

When I look at Hassans Todo for 1.0 - this will take a bit of time - So I guess 1.0 will be done when Node 8 is already EOL.

Supereg commented 4 years ago

778

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this issue was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this issue was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions.

crxporter commented 3 years ago

Can I add a bump and a vote for this? Semantic versioning would be helpful so we know about all breaking changes and can act accordingly!

As always, thanks for all your hard work!

Supereg commented 3 years ago

v1.0.0 is planned to be the next release (apart from potential 0.9.x Bug fix releases).

crxporter commented 2 years ago

v1.0.0 is planned to be the next release (apart from potential 0.9.x Bug fix releases).

So, it's been another year and we've gone through 0.9 and now 0.10... any new plans for 1.0 and true semver support?

crxporter commented 1 year ago

Hello again. I'm back with a yearly reminder that the projects who depend on this library would really appreciate semantic versioning.

Is 2023 the year?!

crxporter commented 5 months ago

Please?

How many more years do I need to come beg for this until we get semver and bump to 1.0?

hjdhjd commented 5 months ago

Some day, but not today. It will come…a little housecleaning first.

Shaquu commented 3 months ago

Bump :)

Guys, SemVer is a very good thing.

Also, in node based projects, it allows using version regex in package.json, at the end, someone will be able to automatically update to some bugfix version without the need to pull the change manually by each project.

hjdhjd commented 3 months ago

We intend to do this in the near future. No need to keep bumping this...it's already on our radar.

Shaquu commented 3 months ago

@hjdhjd After my bump there is a PR ;) https://github.com/homebridge/HAP-NodeJS/pull/1045

crxporter commented 3 months ago

We intend to do this in the near future. No need to keep bumping this...it's already on our radar.

It's been nearly 5 years of "coming soon" and "next release" promises. You've got to understand why we feel forgotten.

I appreciate finally seeing some progress on it this year. Thanks! I hope it actually does come in the next release!

hjdhjd commented 3 months ago

We intend to do this in the near future. No need to keep bumping this...it's already on our radar.

It's been nearly 5 years of "coming soon" and "next release" promises. You've got to understand why we feel forgotten.

I appreciate finally seeing some progress on it this year. Thanks! I hope it actually does come in the next release!

Correlation isn’t causation. Closing this.

Shaquu commented 3 months ago

lol

hjdhjd commented 3 months ago

Reopening until we actually release 1.0.0…got ahead of myself. 😄

hjdhjd commented 3 months ago

We intend to do this in the near future. No need to keep bumping this...it's already on our radar.

It's been nearly 5 years of "coming soon" and "next release" promises. You've got to understand why we feel forgotten.

I appreciate finally seeing some progress on it this year. Thanks! I hope it actually does come in the next release!

It will come…we had a couple of things to close out which have been in the past few days/weeks…there’s one more potentially, but we may push it to a post-1.0 release.

Shaquu commented 2 months ago

GG