coveralls
commented
2 years ago Pull Request Test Coverage Report for Build 2230313822
- 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage decreased (-0.04%) to 35.733%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| src/NetworkManager.ts | 0 | 3 | 0.0% | ||
| <!-- | Total: | 0 | 3 | 0.0% | --> |
| Totals | |
|---|---|
| Change from base Build 1491628923: | -0.04% |
| Covered Lines: | 1200 |
| Relevant Lines: | 3047 |
:recycle: Current situation
https://github.com/nodejs/node/issues/42787 https://github.com/nodejs/node/pull/41431#discussion_r841277378
:bulb: Proposed solution
It's worth doing this sooner rather than later. There may be other compatibility issues in Node.js 18 we won't find until this one is patched.
The use of
@ts-expect-errorshould alert us to remove the exception when @types/node is updated to 18 (if they decide to keep backwards compatibility with old versions, which they may not, be we need to).Alternatively we could do something like this, but I feel like it will result in the exception never being removed in the future:
:gear: Release Notes
Reviewer Nudging
@Supereg