homebridge / ciao

RFC 6762 and RFC 6763 compliant mdns service discovery library written in Typescript
MIT License
81 stars 6 forks source link

npm update issues unsupported engine warning #30

Closed n0rt0nthec4t closed 1 year ago

n0rt0nthec4t commented 1 year ago

Current Situation

performing an npm update command issues unsupported engine warning with CIAO v1.1.6 library

Logs

pi@nodejsdev:~$ npm update
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '@homebridge/ciao@1.1.6',
npm WARN EBADENGINE   required: { node: '^14' },
npm WARN EBADENGINE   current: { node: 'v18.16.0', npm: '9.5.1' }
npm WARN EBADENGINE }

Configuration

pi@nodejsdev:~$ npm list
pi@ /home/pi
├── axios@1.4.0
├── ffmpeg-for-homebridge@0.1.4
├── h264-sps-parser@0.2.1
├── hap-nodejs@0.11.1
├── pbf@3.2.1
├── rpio@2.4.2
└── ws@8.13.0

Environment

Process Supervisor

not applicable

Additional Context

No response

pgerke commented 1 year ago

Looking at the changes between v1.1.5 and v1.1.6, especially https://github.com/homebridge/ciao/compare/v1.1.5...v1.1.6#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R73-R75 I could imagine a typo. I'd expect the intent was not to limit engines to Node 14, but to a node version larger than or equal to Node 14:

{
  ...
  "engines": {
    "node": ">=14"
  }
}