search

homebridge / ciao

RFC 6762 and RFC 6763 compliant mdns service discovery library written in Typescript
MIT License
79 stars 6 forks source link

fix [#30]: Fix unsupported engine warning #31

Closed pgerke closed 1 year ago

pgerke commented 1 year ago

:recycle: Current situation

The issue is well described in https://github.com/homebridge/ciao/issues/30

:bulb: Proposed solution

In the package.json file, change the node requirement in the engines element to allow all node version larger than or equal to Node 14.

:gear: Release Notes

Fixed an issue with the node version requirements.

:heavy_plus_sign: Additional Information

N/A

Testing

The change only affects the package.json. No source code or tests were touched.

Reviewer Nudging

The package.json 😉

TA2k commented 1 year ago

@Supereg Please merge this PR as soon as possible. Because the current 1.1.6 version is blocking all package with homebridge as dependency

@oznu @AppleTechy

Supereg commented 1 year ago

This PR includes more changes than what it describes. Will fix the issue tonight though.

pgerke commented 1 year ago

The only changes besides the engines fix are a version number bump according to semver and the corresponding documentation update that was done by npm run version.

TA2k commented 1 year ago

Ok for me it looks like only the change and bump to 1.1.7

Supereg commented 1 year ago

v1.1.7 is live any minute now