Closed donavanbecker closed 5 months ago
i’m afraid i won’t be a good reviewer of this as (1) i don’t enough about this subject and best practises etc and (2) i cant even reproduce locally to check whether the changes is general work or not!
@hjdhjd, Homebridge v1.8.4-alpha.18 has these changes and looks like it is working as expected. I will remove my commented out sections.
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
src/util/v4mapped.ts | 6 | 7 | 85.71% | ||
src/util/domain-formatter.ts | 15 | 22 | 68.18% | ||
<!-- | Total: | 30 | 38 | 78.95% | --> |
Totals | |
---|---|
Change from base Build 9729372371: | -0.2% |
Covered Lines: | 1190 |
Relevant Lines: | 3084 |
:recycle: Current situation
Currently IPv4-mapped IPv6 addresses are not supported
:bulb: Proposed solution
Add support for IPv4-mapped IPv6 addresses
:gear: Release Notes
Added support for IPv4-mapped IPv6 addresses
:heavy_plus_sign: Additional Information
Not sure if there is anything else that needs to be changed?
Testing
Install tvOS 18 or macOS 15 beta
or
a device that has an IPv4-mapped IPv6 address.
Reviewer Nudging
tvOS 18 is what is causing the issue indicated in #41, but others have reported it with macOS 15 beta.