search

homebridge / docker-homebridge

Homebridge Docker. HomeKit support for the impatient using Docker on x86_64, Raspberry Pi (armhf) and ARM64. Includes ffmpeg + libfdk-aac.
https://hub.docker.com/r/homebridge/homebridge/
GNU General Public License v3.0
2.57k stars 241 forks source link

docker publish should has a version tag not just ubuntu #541

Closed kis87988 closed 6 months ago

kis87988 commented 6 months ago

Describe The Bug

As title, I believe the docker image release should have a tag, otherwise you will have hard time to track what version install under the docker image in the future

Docker Config

N/A

Logs

No response

Host Operating System

Synology DSM 6

Host Architecture

x86_64 / amd64

NorthernMan54 commented 6 months ago

Humm, I think we are publishing tags ? - https://hub.docker.com/r/homebridge/homebridge/tags

kis87988 commented 6 months ago

hmmm. Interesting, yesterday I checked the latest tag was 3 months ago. Today it becomes 2023-12-28 to match the latest tag. However, shouldn't we match the homebridge version number as tag?

NorthernMan54 commented 6 months ago

The push today is a bit of a coincidence, as another collaborator made a change today that triggered the build script.

Are you sure the previous tag was 3 months ago, I thought it was Nov 28th ? My last update

donavanbecker commented 6 months ago

Today it becomes 2023-12-28 to match the latest tag. However, shouldn't we match the homebridge version number as tag?

There is more then just homebridge that is include in this docker image. so matching up with the homebridge version wouldn't make sense.

kis87988 commented 6 months ago

check via docker image I did docker pull homebridge/homebridge:latest yesterday.

homebridge/homebridge              latest    6fe8959f69b5   4 weeks ago     966MB
NorthernMan54 commented 6 months ago

Am thinking we can close this

NorthernMan54 commented 6 months ago

Just published a formal refresh today, and noticed the tags not working as expected. So needed to redo the publish. @kis87988 You may have seen the same issue. Tks for reporting this