homebridge / homebridge-config-ui-x

The Homebridge UI. Monitor, configure and backup Homebridge from a browser.
https://homebridge.io
MIT License
2.61k stars 373 forks source link

Fix for backup service including npm's cache, and therefore being too large to upload generating a zlib error #1948

Closed sapireli closed 9 months ago

sapireli commented 9 months ago

Fix for backups including npm's cache, and therefore being too large to upload and restore.

closes #1856

:recycle: Current situation

see #1856

:bulb: Proposed solution

add '.npm' folder to ignored files/folders list

:gear: Release Notes

Bug Fixes

Testing

I was finally able to backup and restore successfully with this change.

bwp91 commented 9 months ago

Hi @sapireli thanks for the PR! Please could you

@NorthernMan54 can you think of any risks of adding this as an ignored folder in the backup file?

bwp91 commented 9 months ago

Hi @sapireli thanks for sorting that out, we will get this added to the changelog.

Could you also revert the new line changes to the package/lock json files? just so there is simply one file change in the PR?

Then will get this added into beta branch asap 👍

sapireli commented 9 months ago

Just made a new pull request, rebases and me don't get along very well. Thank you @bwp91