search

homebridge / node-pty-prebuilt-multiarch

A parallel fork of node-pty providing ia32, amd64, arm, and aarch64 prebuilt packages for macOS, Windows and Linux (glibc and musl libc).
https://www.npmjs.com/package/@homebridge/node-pty-prebuilt-multiarch
Other
31 stars 15 forks source link

Prebuilt windows binaries electron 3.x aka ABI 64 dont seem to work #1

Closed the-j0k3r closed 5 years ago

the-j0k3r commented 5 years ago

Environment details

Issue description

Using platformio-ide-terminal@2.9.3 which switched from node-pty-prebuilt 0.7.6 being compatible with Atom/ up to 1.38.2 electron version 2.0.0 and fully working with platformio-ide-terminal@2.9.1, now with Atom 1.39.1 and node-pty-prebuilt-multiarch 0.8.1 the terminal has only a blinking cursor.

Using rebuilt binaries with python 2.7.16 works, but the binaries here for at least Windows dont.

Rebuilt working binaries Release.zip

Prebuilt non working binaries. Release-prebuilt.zip

I suspect its the python version used to compile them in this repo, but it could be something else that eludes me at this time.

oznu commented 5 years ago

I don't build for Electron 3.0 on Windows 10.

https://github.com/oznu/node-pty-prebuilt-multiarch/blob/prebuilt-multiarch/.travis.yml#L63-L67

I'm sure there was a reason why, but I'll try updating it to see.

the-j0k3r commented 5 years ago

Appreciated

oznu commented 5 years ago

It seemed to work in Travis.

To install use the next tag:

npm install node-pty-prebuilt-multiarch@next

For some reason the Windows builds are being marked as failed even though they pass and exit with code 0. I'm going to ignore that issue for now as it's not actually breaking anything and probably just a Travis thing.

image

the-j0k3r commented 5 years ago

Well but how to solve this as a dependency for platformio-ide-terminal? It needs prebuilt binaries there.

I chose this project because node-pty-prebuilt has pretty much been silent for months and its incompatible with electron 3.x and higher in some platforms, which Atom 1.39.1 is sporting

oznu commented 5 years ago

Replacing ^0.8.1 with 0.9.0-beta21.1 should do it.

I can't rebuild 0.8.1 as it's got some issues making it incompatible with the latest Node.js version - hence why I'm building the pre-release betas.

the-j0k3r commented 5 years ago

OK will do that, though I noticed that there are no electron 3.x prebuilds for macOS https://github.com/oznu/node-pty-prebuilt-multiarch/blob/6e960ae0c55f95c35af41f8fbdec8dcd75d0dea6/.travis.yml#L61 :sob:

Im not ure about Linux side, does that support electron 3.x? If not would you also?

the-j0k3r commented 5 years ago

Ah I see Linux builds all... its just that pesky macOS failing for some reason. =(

the-j0k3r commented 5 years ago

THe Windows builds Travis fails because of failed to upload cache, so it can be ignored or if a fix is possible apply it.

Here is relevant part of log.

prebuild info build Prebuild written to prebuilds\node-pty-prebuilt-multiarch-v0.9.0-beta21.1-electron-v70-win32-ia32.tar.gz
1823
gzip: warning: GZIP environment variable is deprecated; use an alias or script
1824
uploading cache-windows-1803-containers-e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855--node-lts/*.tgz
1825
failed to upload cache
the-j0k3r commented 5 years ago

Seems working now both with this and 0.9.0-beta21.legacy both Windows macoOS Linux

Closing, and thank you again so much.