homebridge / node-pty-prebuilt-multiarch

A parallel fork of node-pty providing ia32, amd64, arm, and aarch64 prebuilt packages for macOS, Windows and Linux (glibc and musl libc).
https://www.npmjs.com/package/@homebridge/node-pty-prebuilt-multiarch
Other
31 stars 15 forks source link

Support Electron > 18 #34

Closed seydx closed 12 months ago

seydx commented 12 months ago

:recycle: Current situation

Describe the current situation. Explain current problems, if there are any. Be as descriptive as possible (e.g., including examples or code snippets).

The current version only supports Electron up to v18 and the compiling process for Electron > 18 is failing because c++ 17 is required

:bulb: Proposed solution

Describe the proposed solution and changes. How does it affect the project? How does it affect the internal structure (e.g., refactorings)?

:gear: Release Notes

Provide a summary of the changes or features from a user's point of view. If there are breaking changes, provide migration guides using code examples of the affected features.

:heavy_plus_sign: Additional Information

If applicable, provide additional context in this section.

Testing

Which tests were added? Which existing tests were adapted/changed? Which situations are covered, and what edge cases are missing?

Reviewer Nudging

Where should the reviewer start? what is a good entry point?