homebridge / node-pty-prebuilt-multiarch

A parallel fork of node-pty providing ia32, amd64, arm, and aarch64 prebuilt packages for macOS, Windows and Linux (glibc and musl libc).
https://www.npmjs.com/package/@homebridge/node-pty-prebuilt-multiarch
Other
31 stars 15 forks source link

No prebuilt binaries found (target=4.2.7 runtime=node arch=x64 libc= platform=win32) #7

Closed UziTech closed 5 years ago

UziTech commented 5 years ago

Environment details

Issue description

Trying to use platformio-ide-terminal on Atom v1.41.0-beta0

No prebuilt binaries found (target=4.2.7 runtime=node arch=x64 libc= platform=win32)

related https://github.com/platformio/platformio-atom-ide-terminal/issues/766

the-j0k3r commented 5 years ago

I can confirm from two independent sources that macOS and Linux and flavours work fine with electron 4.2.7, its just Windows binaries that seem to be affected with this issue. I need to test locally other tags to see if I can narrow this down.

I know this is very likely unrelated but I have submitted a PR to fix the Windows builds completion. Ive no idea if that has any bearing on issue, likely not since electron 3.x builds works in all 3 macOS/Windows/Linux

edit I also have compiled specifically to electron 4.2.0(<-build log @travis-ci) code change https://github.com/the-j0k3r/node-pty-prebuilt-multiarch/commit/39d54aecd1da22efa7045ac328e7856466c34cf4 this is not part of the node-abi but compiles, if it works IDK. didnt dump the compiled binaries to test.

the-j0k3r commented 5 years ago

ping

the-j0k3r commented 5 years ago

@UziTech see https://github.com/atom/atom/issues/19780 the cause of all the trouble,

the-j0k3r commented 5 years ago

I think its safe to close this issue.