homebridge-comelit-platform

madchicken commented 4 years ago

Plugin Details An Homebridge platform plugin to expose Comelit Home Automation devices.

Plugin Name: homebridge-comelit-platform
Link To GitHub Repo: https://github.com/madchicken/homebridge-comelit-hub
Link To NPM Package: https://www.npmjs.com/package/homebridge-comelit-platform

github-actions[bot] commented 4 years ago

:white_check_mark: Pre-checks completed successfully.

donavanbecker commented 4 years ago

[x] - The plugin must successfully install.
[x] - The plugin must implement the Homebridge Plugin Settings GUI.
[x] - The plugin must not start unless it is configured.
[x] - The plugin must not execute post-install scripts that modify the user's system in any way.
[x] - The plugin must not contain any analytics or calls that enable you to track the user.
[x] - The plugin must not throw unhandled exceptions, the plugin must catch and log its own errors.
[x] - The plugin must be published to npm and the source code available on GitHub.
[x] - The plugin must run on all Active LTS versions of Node.js, at the time of writing this is Node.js v10 and v12.
[x] - The plugin must not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.
[x] - If the plugin needs to write files to disk (cache, keys, etc.), it must store them inside the Homebridge storage directory.

Everything looks good!

Is there a reason why you are setting all as default? instead of using placeholder?

github-actions[bot] commented 4 years ago

Congratulations! Your plugin has been verified.

You can now add the Verified by Homebridge badge to your plugin's README:

[![verified-by-homebridge](https://badgen.net/badge/homebridge/verified/purple)](https://github.com/homebridge/homebridge/wiki/Verified-Plugins)

Your plugin is now also eligible to display a :heart: Donate button on it's tile in the Homebridge UI. See https://github.com/oznu/homebridge-config-ui-x/wiki/Developers:-Donation-Links for instructions.

Thank you for your contribution to the Homebridge Community. https://homebridge.io

donavanbecker commented 4 years ago

homebridge / plugins