homebridge / plugins

Information and resources for Homebridge plugins.
https://homebridge.io/w/Verified-Plugins
GNU General Public License v3.0
366 stars 17 forks source link

homebridge-sonos-starter-track #321

Closed planetWayne closed 3 years ago

planetWayne commented 3 years ago

This plug in allows you to make use of the Sonos HTTP API to be able to start and stop configuration 'presets' as defined with Sonos HTTP API. The idea being that this will expose these presets as 'switches' to Homekit thus allowing you to 'turn on' a preset to start playing a specified track, at a volume on a player.

My variation builds from the original and allows you to specify a 'trackURI' to look out for as having multiple of these switches defined can lead to a host of 'on' devices. This could then let you identify a stream that is playing rather than all the Sono's be 'on'

This is my first attempt at verification and fully expect to not be up to scratch and therefor guidance and to what needs improving. Thanks Wayne.

github-actions[bot] commented 3 years ago

:white_check_mark: Pre-checks completed successfully.

donavanbecker commented 3 years ago

(node:58338) UnhandledPromiseRejectionWarning: Error: You must provide a config value for 'preset'.
    at new SonosAccessory (/usr/local/lib/node_modules/homebridge-sonos-starter-track/index.js:48:33)
    at ChildBridgeFork.startBridge (/usr/local/lib/node_modules/homebridge/src/childBridgeFork.ts:156:52)
(Use `node --trace-warnings ...` to show where the warning was created)
(node:58338) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:58338) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
planetWayne commented 3 years ago

Hi, Just want to check procedure. I'm assuming that when I've fixed the issue, that I need to increase on the version number and republish, but do I need to resubmit a new verification request or can I post back here to say that it has been updated?

Thanks Wayne.

donavanbecker commented 3 years ago

Hi,

Just want to check procedure. I'm assuming that when I've fixed the issue, that I need to increase on the version number and republish, but do I need to resubmit a new verification request or can I post back here to say that it has been updated?

Thanks

Wayne.

Just post back here with a /check to trigger the plugin check again once you have published the next version.

planetWayne commented 3 years ago

/check

github-actions[bot] commented 3 years ago

:white_check_mark: Pre-checks completed successfully.

github-actions[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

planetWayne commented 3 years ago

Hi @donavanbecker , Got a notification to say that this has gone stale, I did do the /Check as required. Did I miss something?

Thanks Wayne.

donavanbecker commented 3 years ago

Sorry saw that, but didn't see any comments on if you got it fixed our not.

planetWayne commented 3 years ago

Hi @donavanbecker , My apologies, I have uploaded a new version that hopefully addresses the issues you found for the verification process. The corrected version is now on v1.0.18.

I must admit, not knowing the process and that there are bots in place I look your response to literally mean to just post back with the /check to kick start the process again.

Do I have to re-apply or is it possible to move forward with this application?

Thanks again, Wayne.

github-actions[bot] commented 3 years ago

Congratulations! Your plugin has been verified.

You can now add the Verified by Homebridge badge to your plugin's README:

verified-by-homebridge

[![verified-by-homebridge](https://badgen.net/badge/homebridge/verified/purple)](https://github.com/homebridge/homebridge/wiki/Verified-Plugins)

Your plugin is now also eligible to display a :heart: Donate button on it's tile in the Homebridge UI. See https://github.com/oznu/homebridge-config-ui-x/wiki/Developers:-Donation-Links for instructions.

Thank you for your contribution to the Homebridge Community. https://homebridge.io

planetWayne commented 3 years ago

Hi @donavanbecker !! Thankyou for seeing this through! I'm extremely pleased that I've been able to get verification status! I realise that this is only a small little plug-in the the grand scheme of things especially when compared to the huge plugins and Homebridge system as a whole - but from my point of view, I am really grateful ! (I must confess to literally punching the air when the email dropped!)

Thank you again!

If you don't mind, a couple of quick follow up questions, now that this is verified, at what point does it show that in Homebridge UI? Is it enough to update the Github page to have the new verified badge or does NPM also need an update? Also, if I do update the version, does this need another resubmission?

Yours Wayne.

donavanbecker commented 3 years ago

It will show up on the next update if config UI or if you restart the UI manually.