homebridge / plugins

Information and resources for Homebridge plugins.
https://homebridge.io/w/Verified-Plugins
GNU General Public License v3.0
368 stars 17 forks source link

homebridge-level-sense #530

Closed waltmoorhouse closed 1 year ago

waltmoorhouse commented 1 year ago

Link To GitHub Repo

https://github.com/waltmoorhouse/homebridge-level-sense

Link To NPM Package

https://www.npmjs.com/package/homebridge-level-sense

github-actions[bot] commented 1 year ago

:white_check_mark: Pre-checks completed successfully.

bwp91 commented 1 year ago

Hi @waltmoorhouse

My comments here would be the same as the other plugin https://github.com/homebridge/verified/issues/529

  1. about the name property in the config schema file
  2. this is most likely a very picky comment (so sorry!) but I noticed in the log when I configured incorrect credentials
    [12/04/2023, 22:35:36] [homebridge-level-sense] ERROR: unable to fetch devices - Please provide session key
    [12/04/2023, 22:35:36] [homebridge-level-sense] Updating device readings.
    [12/04/2023, 22:35:36] [homebridge-level-sense] Discovery action completed

    i just wondered whether there is some unnecessary interval going on that could be removed in the case that the plugin has never been able to set up properly.


otherwise all seems good to happy to verify 😁

bwp91 commented 1 year ago

Congratulations! Your plugin has been verified.

You can now add the Verified by Homebridge badge to your plugin's README:

verified-by-homebridge

[![verified-by-homebridge](https://badgen.net/badge/homebridge/verified/purple)](https://github.com/homebridge/homebridge/wiki/Verified-Plugins)

Your plugin is now also eligible to display a :heart: Donate button on its tile in the Homebridge UI. See https://github.com/oznu/homebridge-config-ui-x/wiki/Developers:-Donation-Links for instructions.

If for any reason in the future you can no longer maintain your plugin, please consider transferring it to our unmaintained plugins repo. We can take ownership until another willing developer comes along.

Thank you for your contribution to the Homebridge Community. https://homebridge.io