Verification Request: homebridge-jci-hitachi-platform

tasict commented 10 months ago

Plugin Name

homebridge-jci-hitachi-platform

Link To GitHub Repo

https://github.com/tasict/homebridge-jci-hitachi-platform

Link To NPM Package

https://www.npmjs.com/package/homebridge-jci-hitachi-platform

Plugin Icon (Optional)

No response

github-actions[bot] commented 10 months ago

:white_check_mark: Pre-checks completed successfully.

bwp91 commented 9 months ago

This plugin is also showing the homebridge verified badge on the readme when it is not verified yet

tasict commented 9 months ago

Ok,I will remove it and update.

tasict commented 9 months ago

@bwp91 Hi, I have modified the code and documentation. Please assist in reviewing the latest version. Thank you.

github-actions[bot] commented 8 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

tasict commented 8 months ago

@bwp91 Any update?

github-actions[bot] commented 8 months ago

General
- [x] The plugin must be of type dynamic platform.
- [x] The plugin must not offer the same nor less functionality than that of any existing verified plugin.
Repo
- [x] The plugin must be published to NPM and the source code available on a GitHub repository, with issues enabled.
- [ ] A GitHub release should be created for every new version of your plugin, with release notes.
Environment
- [x] The plugin must run on all supported LTS versions of Node.js, at the time of writing this is Node v18 and v20.
- [ ] The plugin must successfully install and not start unless it is configured.
- [ ] The plugin must not execute post-install scripts that modify the users' system in any way.
- [ ] The plugin must not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.
Codebase
- [ ] The plugin must implement the Homebridge Plugin Settings GUI.
- [ ] The plugin must not contain any analytics or calls that enable you to track the user.
- [ ] If the plugin needs to write files to disk (cache, keys, etc.), it must store them inside the Homebridge storage directory.
- [ ] The plugin must not throw unhandled exceptions, the plugin must catch and log its own errors.

Comment `/check` to run checks again.

bwp91 commented 8 months ago

Hi @tasict

I just installed the plugin but have not yet configured it. When I restart Homebridge I get this in the logs (although it does not seem to affect my homebridge).

[16/03/2024, 18:22:57] ====================
[16/03/2024, 18:22:57] ERROR LOADING PLUGIN homebridge-jci-hitachi-platform:
[16/03/2024, 18:22:57] Error: AWS CRT binary not present in any of the following locations:
        /usr/local/lib/node_modules/homebridge-jci-hitachi-platform/node_modules/aws-crt/dist/bin/linux-arm-glibc/aws-crt-nodejs.node
    at Object.<anonymous> (/usr/local/lib/node_modules/homebridge-jci-hitachi-platform/node_modules/aws-crt/lib/native/binding.js:88:11)
    at Module._compile (node:internal/modules/cjs/loader:1376:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1435:10)
    at Module.load (node:internal/modules/cjs/loader:1207:32)
    at Function.Module._load (node:internal/modules/cjs/loader:1023:12)
    at Module.require (node:internal/modules/cjs/loader:1235:19)
    at require (node:internal/modules/helpers:176:18)
    at Object.<anonymous> (/usr/local/lib/node_modules/homebridge-jci-hitachi-platform/node_modules/aws-crt/lib/native/auth.ts:15:1)
    at Module._compile (node:internal/modules/cjs/loader:1376:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1435:10)
[16/03/2024, 18:22:57] ====================

I noticed that the installation took a long time and seems to download a load of extra stuff (which is not necessarily an issue by itself).

I assume all this is from the aws-iot-device-sdk-v2 dependency.

In my Govee plugin I use aws-iot-device-sdk and tried the -v2 but reverted back due to all the extra stuff that happened during installation. Do you need to use the v2 with your plugin or would it be possible/easy to change to using the original aws-iot-device-sdk?

tasict commented 8 months ago

Because my plugins are newly written, I'm not very familiar with the aws-iot-device-sdk. I simply used it because Hitachi employs AWS's IoT service. During implementation, I found that there are two versions available. The official recommendation on the website is to use the newer v2 version. I also have concerns that the v1 version may be discontinued in the near future, so I initially chose the v2 version.

github-actions[bot] commented 7 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 6 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 4 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 3 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

bwp91 commented 2 months ago

/check

github-actions[bot] commented 2 months ago

🔴 The following checks failed:

Package JSON: failed to import plugin as ENOENT: no such file or directory, open '/workspace/test-area/node_modules/https:/github.com/tasict/homebridge-jci-hitachi-platform/package.json'
NPM Package: could not request information as Unexpected end of JSON input
Config Schema JSON: missing file

🟢 The following checks passed:

Installation: successfully installed
Dependencies: homebridge was not installed as a dependency
Dependencies: hap-nodejs was not installed as a dependency

⚠️ Please action these failures and then comment /check to run the checks again. Let us know if you need any help.

If updating your package.json and config.schema.json files, don't forget to publish a new version to NPM.

bwp91 commented 2 months ago

/check

github-actions[bot] commented 2 months ago

🔴 The following checks failed:

GitHub Repo: should contain releases

🟢 The following checks passed:

Installation: successfully installed
Package JSON: homepage exists
Package JSON: bugs.url exists and seems a valid URL
Package JSON: keywords exist and contain 'homebridge-plugin'
Package JSON: 'preinstall' in scripts is not present
Package JSON: 'install' in scripts is not present
Package JSON: 'postinstall' in scripts is not present
Package JSON: engines.node property is compatible with Node 18
Package JSON: engines.node property is compatible with Node 20
Package JSON: engines.homebridge property is compatible with Homebridge 1.8.4
Package JSON: initializer function found
GitHub Repo: repository is public
GitHub Repo: repository is not archived
GitHub Repo: issues are enabled
NPM Package: has not been deprecated
Config Schema JSON: exists and is valid JSON
Config Schema JSON: contains a valid pluginAlias
Config Schema JSON: the pluginType is set to 'platform'
Config Schema JSON: contains a name schema property
Dependencies: homebridge was not installed as a dependency
Dependencies: hap-nodejs was not installed as a dependency

⚠️ Please action these failures and then comment /check to run the checks again. Let us know if you need any help.

If updating your package.json and config.schema.json files, don't forget to publish a new version to NPM.

tasict commented 2 months ago

/check

github-actions[bot] commented 2 months ago

🟢 The following checks passed:

Installation: successfully installed
Package JSON: homepage exists
Package JSON: bugs.url exists and seems a valid URL
Package JSON: keywords exist and contain 'homebridge-plugin'
Package JSON: 'preinstall' in scripts is not present
Package JSON: 'install' in scripts is not present
Package JSON: 'postinstall' in scripts is not present
Package JSON: engines.node property is compatible with Node 18
Package JSON: engines.node property is compatible with Node 20
Package JSON: engines.homebridge property is compatible with Homebridge 1.8.4
Package JSON: initializer function found
GitHub Repo: repository is public
GitHub Repo: repository is not archived
GitHub Repo: issues are enabled
GitHub Repo: contains releases
NPM Package: has not been deprecated
Config Schema JSON: exists and is valid JSON
Config Schema JSON: contains a valid pluginAlias
Config Schema JSON: the pluginType is set to 'platform'
Config Schema JSON: contains a name schema property
Dependencies: homebridge was not installed as a dependency
Dependencies: hap-nodejs was not installed as a dependency

🎉 All checks passed successfully, nice work! Your plugin and/or icon will now be manually reviewed by the Homebridge team.

MarijoVidovic commented 1 day ago

Encountering Error: AWS CRT binary not present in any of the following locations. Is there any update for this? :)

MarijoVidovic commented 1 day ago

After analyzing and time spent debugging I would say name of this plugin is misleading. It supports only Asia and AC in Asia not worldwide so I would suggest plugin rename and update to readme specifying which region and ac are supported

This way people got hooked on it, spent time on it just to find out its waste of time Thanks

homebridge / plugins