search

homebridge / plugins

Information and resources for Homebridge plugins.
https://homebridge.io/w/Verified-Plugins
GNU General Public License v3.0
368 stars 17 forks source link

nest-cam and fordpass #695

Closed Brandawg93 closed 8 months ago

Brandawg93 commented 9 months ago

:recycle: Current situation

Describe the current situation. Explain current problems, if there are any. Be as descriptive as possible (e.g., including examples or code snippets).

:bulb: Proposed solution

Describe the proposed solution and changes. How does it affect the project? How does it affect the internal structure (e.g., refactorings)?

:gear: Release Notes

Provide a summary of the changes or features from a user's point of view. If there are breaking changes, provide migration guides using code examples of the affected features.

:heavy_plus_sign: Additional Information

If applicable, provide additional context in this section.

Testing

Which tests were added? Which existing tests were adapted/changed? Which situations are covered, and what edge cases are missing?

Reviewer Nudging

Where should the reviewer start? what is a good entry point?

bwp91 commented 8 months ago

Hi @Brandawg93

Thanks for this, I cherry-picked and edited the commit to include the icons in the json list too:

https://github.com/homebridge/verified/commit/240e29fc02a0fbf1599b4847327d81e7aafd80ee

Gonna close this PR as no longer needed 👍