homebridge / plugins

Information and resources for Homebridge plugins.
https://homebridge.io/w/Verified-Plugins
GNU General Public License v3.0
368 stars 16 forks source link

Verification Request: homebridge-http-sensors-switches #755

Closed kreso975 closed 2 months ago

kreso975 commented 2 months ago

Plugin Name

homebridge-http-sensors-switches

Link To GitHub Repo

https://github.com/kreso975/homebridge-http-sensors-switches

Plugin Icon (Optional)

No response

The plugin does not offer the same nor less functionality than that of any existing verified plugin.

🟒 Yes

The plugin successfully installs and does not start unless it is configured.

🟒 Yes

The plugin does not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.

🟒 Yes

The plugin does not contain any analytics or calls that enable you to track the user.

🟒 Yes

If the plugin needs to write files to disk (cache, keys, etc.), it stores them inside the Homebridge storage directory.

🟒 Yes

The plugin does not throw unhandled exceptions, the plugin must catch and log its own errors.

🟒 Yes

More Information

Hi,

This is simple HTTP plugin covering Interaction with Switch and reading Sensor JSON data. Each accessory can be adjusted inside config (see Config example). Main reason i have wrote this code is not to be dependent on non maintained plugins which were causing my homebridge to crash. I'm using it on iot devices built by my self.

There are similar plugins out there but none of them are verified. I'm new to this kind of process, I hope i did it OK :)

Best regards, Kreso

github-actions[bot] commented 2 months ago

πŸ”΄ The following checks failed:


🟒 The following checks passed:


⚠️ Please action these failures and then comment /check to run the checks again. Let us know if you need any help.

If updating your package.json and config.schema.json files, don't forget to publish a new version to NPM.

kreso975 commented 2 months ago

/check

github-actions[bot] commented 2 months ago

🟒 The following checks passed:


πŸŽ‰ All checks passed successfully, nice work! Your plugin and/or icon will now be manually reviewed by the Homebridge team.

github-actions[bot] commented 2 months ago
bwp91 commented 2 months ago

/check

github-actions[bot] commented 2 months ago
github-actions[bot] commented 2 months ago

🟒 The following checks passed:


πŸŽ‰ All checks passed successfully, nice work! Your plugin and/or icon will now be manually reviewed by the Homebridge team.

bwp91 commented 2 months ago

Hi @kreso975 I think your config.schema.json file isn't quite right, and it is only showing the name and description fields in the UI settings.

Screenshot 2024-09-22 at 09 55 08

I think you need to move this devices up into schema.properties

https://github.com/kreso975/homebridge-http-sensors-switches/blob/e4e622a742bff97414ccbc16a753129850b6c2c8/config.schema.json#L19

kreso975 commented 2 months ago

Hi @bwp91,

Thank you for taking the time to check my plugin. To be honest, I somewhat forgot to properly set up the schema. I wasn’t sure what the best approach would be to get it right. I’ll dig into it, make the necessary adjustments, and let you know.

Thanks again for your time.

Kreso

kreso975 commented 2 months ago

Hi @bwp91, β€œI have rewritten config.schema.json and released an update. It should work now. Please check it and let me know if everything is OK.

bwp91 commented 2 months ago

/test

bwp91 commented 2 months ago

/check

github-actions[bot] commented 2 months ago

🟒 The following checks passed:


πŸŽ‰ All checks passed successfully, nice work! Your plugin and/or icon will now be manually reviewed by the Homebridge team.

github-actions[bot] commented 2 months ago

Congratulations! Your plugin has been verified!

You can now add one of the Verified by Homebridge badges to your plugin's README:

verified-by-homebridge

[![verified-by-homebridge](https://badgen.net/badge/homebridge/verified/purple)](https://github.com/homebridge/homebridge/wiki/Verified-Plugins)

verified-by-homebridge

[![verified-by-homebridge](https://img.shields.io/badge/homebridge-verified-blueviolet?color=%23491F59&style=for-the-badge&logoColor=%23FFFFFF&logo=homebridge)](https://github.com/homebridge/homebridge/wiki/Verified-Plugins)

Your plugin is now also eligible to display a :heart: Donate button on its tile in the Homebridge UI. See https://github.com/homebridge/homebridge/wiki/Donation-Links for instructions.

If for any reason in the future you can no longer maintain your plugin, please consider transferring it to our unmaintained plugins repo. We can take ownership until another willing developer comes along.

Don't forget to join the official Homebridge Discord server, where plugin developers can get tips and advice from other developers and the Homebridge project team in the #plugin-development channel!

As a verified plugin, you can request a channel in the Discord server to discuss your plugin with users and other developers. Just ask in the #plugin-development channel.

Thank you for your contribution to the Homebridge community.

bwp91 commented 2 months ago

config screen looks better now!

kreso975 commented 2 months ago

Thanks a lot @bwp91