search

homebridge / verified

Plugins Verified by Homebridge
https://homebridge.io/w/Verified-Plugins
GNU General Public License v3.0
366 stars 17 forks source link

homebridge-actron-neo #570

Closed bstillitano closed 1 year ago

bstillitano commented 1 year ago

Link To GitHub Repo

https://github.com/bstillitano/homebridge-actron-neo

Link To NPM Package

https://www.npmjs.com/package/homebridge-actron-neo

github-actions[bot] commented 1 year ago

:white_check_mark: Pre-checks completed successfully.

bwp91 commented 1 year ago

Hi @bstillitano

Thanks for this request here!

I have a few questions, and ultimately what I am trying to achieve by this is having less plugins published to npm that appear in the plugin list, so always looking to see if things can be simplified.

I see at the moment your plugin is published to npm as @bstillitano/homebridge-actron-neo.

And when I search npm for actron I see these results:

Screenshot 2023-09-10 at 21 22 08

Im not familiar with this brand, but I see terms like Que and Neo (models?)

Is there a difference between what your plugin provides and what the others don't? Asking especially as I see that homebridge-actron-que is already verified, and wondered if your plugin could be considered a replacement or whether it is for different models of the Actron brand.

Absolutely nothing here to try to catch you out, just a bit of context would be great, and maybe we could find a simpler name for your plugin if you were interested!

Cheers

bstillitano commented 1 year ago

Hey @bwp91

Thanks for your time. Actron is an Australian air conditioning manufacturer who make both split and ducted systems.

The Que and the Neo are two different models that use different APIs and different hardware. So I would call either one a "replacement" of the other. That is to say, you can't use the que plugin on a neo system and vise versa.

Im happy to remove the @bstillitano from the plugin name if that helps at all? I think this is just what NPM put by default.

bwp91 commented 1 year ago

Hi @bstillitano

Thanks for the explanation here, this makes sense.

It's completely up to you about the plugin name. I personally prefer shorter names (and no username-scoped names) but this definitely isn't a verification requirement, so your choice.

I just think homebridge-actron-neo would look good next to homebridge-actron-que!

bstillitano commented 1 year ago

@bwp91 no probs, ill rename the package this evening or tomorrow :)

bstillitano commented 1 year ago

@bwp91 ok, package is renamed now https://www.npmjs.com/package/homebridge-actron-neo

bwp91 commented 1 year ago

@bstillitano nice, thanks for doing that, I am gonna close this issue in favour of:

so that the github actions definitely run against the new plugin name