homebridge / verified

Plugins Verified by Homebridge
https://homebridge.io/w/Verified-Plugins
GNU General Public License v3.0
366 stars 17 forks source link

homebridge-yeelight-ble #582

Closed vsternbach closed 9 months ago

vsternbach commented 10 months ago

Link To GitHub Repo

https://github.com/vsternbach/homebridge-yeelight-ble

Link To NPM Package

https://www.npmjs.com/package/homebridge-yeelight-ble

github-actions[bot] commented 10 months ago

The following pre-checks failed:

:x: Failed to test plugin. :x: Command failed: docker run --rm -e HOMEBRIDGE_PLUGIN_NAME=homebridge-yeelight-ble -v /home/runner/work/verified/verified/precheck/results:/results check

Comment /check to run checks again.

bwp91 commented 10 months ago

/check

github-actions[bot] commented 10 months ago

The following pre-checks failed:

:x: Failed to test plugin. :x: Command failed: docker run --rm -e HOMEBRIDGE_PLUGIN_NAME=homebridge-yeelight-ble -v /home/runner/work/verified/verified/precheck/results:/results check

Comment /check to run checks again.

bwp91 commented 10 months ago

/check

github-actions[bot] commented 10 months ago

:white_check_mark: Pre-checks completed successfully.

vsternbach commented 10 months ago

/check

github-actions[bot] commented 10 months ago

The following pre-checks failed:

:x: Failed to import plugin: Cannot find module 'homebridge/lib/logger' Require stack:

Comment /check to run checks again.

vsternbach commented 10 months ago

What's up with this check failing on import of logger, it imports and works as expected

donavanbecker commented 10 months ago

/check

github-actions[bot] commented 10 months ago

The following pre-checks failed:

:x: Failed to import plugin: Cannot find module 'homebridge/lib/logger' Require stack:

Comment /check to run checks again.

donavanbecker commented 10 months ago

Believe on of the issues is here: import { Logger } from 'homebridge/lib/logger';

You should be using the log function passed through, like this:

public readonly log: Logger, to this: logs() {}

github-actions[bot] commented 9 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 9 months ago

This issue has been closed as no further activity has occurred.