homebridge-appletv-enhanced

maxileith commented 8 months ago

Link To GitHub Repo

https://github.com/maxileith/homebridge-appletv-enhanced

Link To NPM Package

https://www.npmjs.com/package/homebridge-appletv-enhanced

Plugin Icon (Optional)

No response

github-actions[bot] commented 8 months ago

:white_check_mark: Pre-checks completed successfully.

maxileith commented 8 months ago

Issues that relate to this request:

bwp91 commented 8 months ago

Hi @maxileith

your readme states the plugin only works on linux and (maybe) mac - ok.

i don't have a windows to test, but what happens if a windows user tries to install this plugin? at what point does it not work?

maxileith commented 8 months ago

npm won't allow a windows user to install the plugin. In the package.json is specified that the only allowed operating systems are MacOS and Linux.

https://docs.npmjs.com/cli/v10/configuring-npm/package-json#os

maxileith commented 8 months ago

And from the issues raised on GitHub I can tell that actually pretty many users are using MacOS. The issues that were raised by MacOS users in the past were mostly non Mac-specific. So I assume that it runs fine (the raised issues have of course been fixed). But I do not have a Mac to test ...

bwp91 commented 8 months ago

In fact I had just been looking at that os option in the package json, but didn't know if it meant it refused to install on windows, or just printed a warning much like the engines option

maxileith commented 8 months ago

It refuses to install. E.g., when setting the os option to ["win32"] the following will happen when trying to install the package:

❯ npm install -g homebridge-appletv-enhanced-1.0.0.tgz
npm ERR! code EBADPLATFORM
npm ERR! notsup Unsupported platform for homebridge-appletv-enhanced@1.0.0: wanted {"os":"win32"} (current: {"os":"linux"})
npm ERR! notsup Valid os:  win32
npm ERR! notsup Actual os: linux

npm ERR! A complete log of this run can be found in: /home/maxileith/.npm/_logs/2023-12-29T18_38_13_224Z-debug-0.log

Of course, in the homebridge-appletv-enhanced package it is the other way around ("os": ["linux","darwin"]). The above was for demonstration purposes

github-actions[bot] commented 8 months ago

General
- [x] The plugin must be of type dynamic platform.
- [x] The plugin must not offer the same nor less functionality than that of any existing verified plugin.
Repo
- [x] The plugin must be published to NPM and the source code available on a GitHub repository, with issues enabled.
- [x] A GitHub release should be created for every new version of your plugin, with release notes.
Environment
- [x] The plugin must run on all supported LTS versions of Node.js, at the time of writing this is Node v18 and v20.
- [x] The plugin must successfully install and not start unless it is configured.
- [x] The plugin must not execute post-install scripts that modify the users' system in any way.
- [x] The plugin must not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.
Codebase
- [x] The plugin must implement the Homebridge Plugin Settings GUI.
- [x] The plugin must not contain any analytics or calls that enable you to track the user.
- [x] If the plugin needs to write files to disk (cache, keys, etc.), it must store them inside the Homebridge storage directory.
- [x] The plugin must not throw unhandled exceptions, the plugin must catch and log its own errors.

Comment `/check` to run checks again.

bwp91 commented 8 months ago

The plugin must not execute post-install scripts that modify the users' system in any way.

Just checking on this one, your plugin only creates new files in the Homebridge storage directory right? it doesn't make any changes to file outside of this?

maxileith commented 8 months ago

it doesn't make any changes to file outside of this?

That is correct.

This is why I was raising https://github.com/homebridge/homebridge-apt-pkg/issues/16 in the first place.

github-actions[bot] commented 8 months ago

Congratulations! Your plugin has been verified.

You can now add one of the Verified by Homebridge badges to your plugin's README:

[![verified-by-homebridge](https://badgen.net/badge/homebridge/verified/purple)](https://github.com/homebridge/homebridge/wiki/Verified-Plugins)

[![verified-by-homebridge](https://img.shields.io/badge/homebridge-verified-blueviolet?color=%23491F59&style=for-the-badge&logoColor=%23FFFFFF&logo=homebridge)](https://github.com/homebridge/homebridge/wiki/Verified-Plugins)

Your plugin is now also eligible to display a :heart: Donate button on its tile in the Homebridge UI. See https://github.com/homebridge/homebridge/wiki/Donation-Links for instructions.

If for any reason in the future you can no longer maintain your plugin, please consider transferring it to our unmaintained plugins repo. We can take ownership until another willing developer comes along.

Don't forget to join the official Homebridge Discord server, where plugin developers can get tips and advice from other developers and the Homebridge project team in the #plugin-development channel!

Thank you for your contribution to the Homebridge Community. https://homebridge.io

bwp91 commented 8 months ago

Nice idea with the venv for python!

maxileith commented 2 months ago

/check

github-actions[bot] commented 2 months ago

🔴 The following pre-checks failed:

Package JSON: failed to import plugin as ENOENT: no such file or directory, open '/workspace/test-area/node_modules/https:/github.com/maxileith/homebridge-appletv-enhanced/package.json'
NPM Package: could not request information as Unexpected end of JSON input
Config Schema JSON: missing file

🟢 The following pre-checks passed:

Installation: successfully installed
Dependencies: homebridge was not installed as a dependency
Dependencies: hap-nodejs was not installed as a dependency

⚠️ Please action these failures and then comment /check to run the checks again. Let us know if you need any help.

If updating your package.json and config.schema.json files, don't forget to publish a new version to NPM.

maxileith commented 1 month ago

/check

github-actions[bot] commented 1 month ago

🔴 The following pre-checks failed:

Package JSON: failed to import plugin as ENOENT: no such file or directory, open '/workspace/test-area/node_modules/https:/github.com/maxileith/homebridge-appletv-enhanced/package.json'
NPM Package: could not request information as Unexpected end of JSON input
Config Schema JSON: missing file

🟢 The following pre-checks passed:

Installation: successfully installed
Dependencies: homebridge was not installed as a dependency
Dependencies: hap-nodejs was not installed as a dependency

⚠️ Please action these failures and then comment /check to run the checks again. Let us know if you need any help.

If updating your package.json and config.schema.json files, don't forget to publish a new version to NPM.

maxileith commented 1 month ago

Hi @bwp91. I just wanted to retrigger the check to see if my plugin is still compliant or if I have to comply to new requirements regarding verification. However, I do not really understand the error above as my repo definitely does have a package.json.

maxileith commented 19 hours ago

/check

github-actions[bot] commented 19 hours ago

🔴 The following checks failed:

Package JSON: failed to import plugin as ENOENT: no such file or directory, open '/workspace/test-area/node_modules/https:/github.com/maxileith/homebridge-appletv-enhanced/package.json'
NPM Package: could not request information as Unexpected end of JSON input
Config Schema JSON: missing file

🟢 The following checks passed:

Installation: successfully installed
Dependencies: homebridge was not installed as a dependency
Dependencies: hap-nodejs was not installed as a dependency

⚠️ Please action these failures and then comment /check to run the checks again. Let us know if you need any help.

If updating your package.json and config.schema.json files, don't forget to publish a new version to NPM.

homebridge / verified