homebridge-jci-hitachi-platform

tasict commented 5 months ago

Link To GitHub Repo

https://github.com/tasict/homebridge-jci-hitachi-platform

Link To NPM Package

https://www.npmjs.com/package/homebridge-jci-hitachi-platform

Plugin Icon (Optional)

No response

github-actions[bot] commented 5 months ago

:white_check_mark: Pre-checks completed successfully.

bwp91 commented 4 months ago

This plugin is also showing the homebridge verified badge on the readme when it is not verified yet

tasict commented 4 months ago

Ok,I will remove it and update.

tasict commented 4 months ago

@bwp91 Hi, I have modified the code and documentation. Please assist in reviewing the latest version. Thank you.

github-actions[bot] commented 3 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

tasict commented 3 months ago

@bwp91 Any update?

github-actions[bot] commented 3 months ago

General
- [x] The plugin must be of type dynamic platform.
- [x] The plugin must not offer the same nor less functionality than that of any existing verified plugin.
Repo
- [x] The plugin must be published to NPM and the source code available on a GitHub repository, with issues enabled.
- [ ] A GitHub release should be created for every new version of your plugin, with release notes.
Environment
- [x] The plugin must run on all supported LTS versions of Node.js, at the time of writing this is Node v18 and v20.
- [ ] The plugin must successfully install and not start unless it is configured.
- [ ] The plugin must not execute post-install scripts that modify the users' system in any way.
- [ ] The plugin must not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.
Codebase
- [ ] The plugin must implement the Homebridge Plugin Settings GUI.
- [ ] The plugin must not contain any analytics or calls that enable you to track the user.
- [ ] If the plugin needs to write files to disk (cache, keys, etc.), it must store them inside the Homebridge storage directory.
- [ ] The plugin must not throw unhandled exceptions, the plugin must catch and log its own errors.

Comment `/check` to run checks again.

bwp91 commented 3 months ago

Hi @tasict

I just installed the plugin but have not yet configured it. When I restart Homebridge I get this in the logs (although it does not seem to affect my homebridge).

[16/03/2024, 18:22:57] ====================
[16/03/2024, 18:22:57] ERROR LOADING PLUGIN homebridge-jci-hitachi-platform:
[16/03/2024, 18:22:57] Error: AWS CRT binary not present in any of the following locations:
        /usr/local/lib/node_modules/homebridge-jci-hitachi-platform/node_modules/aws-crt/dist/bin/linux-arm-glibc/aws-crt-nodejs.node
    at Object.<anonymous> (/usr/local/lib/node_modules/homebridge-jci-hitachi-platform/node_modules/aws-crt/lib/native/binding.js:88:11)
    at Module._compile (node:internal/modules/cjs/loader:1376:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1435:10)
    at Module.load (node:internal/modules/cjs/loader:1207:32)
    at Function.Module._load (node:internal/modules/cjs/loader:1023:12)
    at Module.require (node:internal/modules/cjs/loader:1235:19)
    at require (node:internal/modules/helpers:176:18)
    at Object.<anonymous> (/usr/local/lib/node_modules/homebridge-jci-hitachi-platform/node_modules/aws-crt/lib/native/auth.ts:15:1)
    at Module._compile (node:internal/modules/cjs/loader:1376:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1435:10)
[16/03/2024, 18:22:57] ====================

I noticed that the installation took a long time and seems to download a load of extra stuff (which is not necessarily an issue by itself).

I assume all this is from the aws-iot-device-sdk-v2 dependency.

In my Govee plugin I use aws-iot-device-sdk and tried the -v2 but reverted back due to all the extra stuff that happened during installation. Do you need to use the v2 with your plugin or would it be possible/easy to change to using the original aws-iot-device-sdk?

tasict commented 3 months ago

Because my plugins are newly written, I'm not very familiar with the aws-iot-device-sdk. I simply used it because Hitachi employs AWS's IoT service. During implementation, I found that there are two versions available. The official recommendation on the website is to use the newer v2 version. I also have concerns that the v1 version may be discontinued in the near future, so I initially chose the v2 version.

github-actions[bot] commented 2 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 1 month ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 2 days ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

homebridge / verified