homebridge / verified

Plugins Verified by Homebridge
https://homebridge.io/w/Verified-Plugins
GNU General Public License v3.0
366 stars 17 forks source link

Verification Request: homebridge-iRobot-v2 #738

Closed taurgis closed 1 week ago

taurgis commented 3 months ago

Plugin Name

homebridge-irobot-v2

Link To GitHub Repo

https://github.com/taurgis/homebridge-irobot-v2

Plugin Icon (Optional)

No response

The plugin does not offer the same nor less functionality than that of any existing verified plugin.

🟢 Yes

The plugin successfully installs and does not start unless it is configured.

🟢 Yes

The plugin does not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.

🟢 Yes

The plugin does not contain any analytics or calls that enable you to track the user.

🟢 Yes

If the plugin needs to write files to disk (cache, keys, etc.), it stores them inside the Homebridge storage directory.

🟢 Yes

The plugin does not throw unhandled exceptions, the plugin must catch and log its own errors.

🟢 Yes

More Information

This is a refactoring and improvement of the abandoned project: homebridge-iRobot

github-actions[bot] commented 3 months ago

🔴 The following pre-checks failed:


⚠️ Please action these failures and then comment /check to run the checks again. Let us know if you need any help.

If updating your package.json and config.schema.json files, don't forget to publish a new version to NPM.

taurgis commented 3 months ago

/check

github-actions[bot] commented 3 months ago

🔴 The following pre-checks failed:


🟢 The following pre-checks passed:


⚠️ Please action these failures and then comment /check to run the checks again. Let us know if you need any help.

If updating your package.json and config.schema.json files, don't forget to publish a new version to NPM.

taurgis commented 3 months ago

/check

github-actions[bot] commented 3 months ago

🟢 The following pre-checks passed:


🎉 All pre-checks passed successfully, nice work! Your plugin and/or icon will now be manually reviewed by the Homebridge team.

github-actions[bot] commented 2 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

taurgis commented 2 months ago

Not stale.

bwp91 commented 1 week ago

/check

github-actions[bot] commented 1 week ago

🔴 The following checks failed:


🟢 The following checks passed:


⚠️ Please action these failures and then comment /check to run the checks again. Let us know if you need any help.

If updating your package.json and config.schema.json files, don't forget to publish a new version to NPM.

bwp91 commented 1 week ago

What is this for in your package json?

"preinstall": "npm install -g nodemon",
taurgis commented 1 week ago

This remained from the original plugin. Will delete it.

taurgis commented 1 week ago

/check

github-actions[bot] commented 1 week ago

🔴 The following checks failed:


🟢 The following checks passed:


⚠️ Please action these failures and then comment /check to run the checks again. Let us know if you need any help.

If updating your package.json and config.schema.json files, don't forget to publish a new version to NPM.

taurgis commented 1 week ago

/check

github-actions[bot] commented 1 week ago

🟢 The following checks passed:


🎉 All checks passed successfully, nice work! Your plugin and/or icon will now be manually reviewed by the Homebridge team.

github-actions[bot] commented 1 week ago
github-actions[bot] commented 1 week ago

Congratulations! Your plugin has been verified!

You can now add one of the Verified by Homebridge badges to your plugin's README:

verified-by-homebridge

[![verified-by-homebridge](https://badgen.net/badge/homebridge/verified/purple)](https://github.com/homebridge/homebridge/wiki/Verified-Plugins)

verified-by-homebridge

[![verified-by-homebridge](https://img.shields.io/badge/homebridge-verified-blueviolet?color=%23491F59&style=for-the-badge&logoColor=%23FFFFFF&logo=homebridge)](https://github.com/homebridge/homebridge/wiki/Verified-Plugins)

Your plugin is now also eligible to display a :heart: Donate button on its tile in the Homebridge UI. See https://github.com/homebridge/homebridge/wiki/Donation-Links for instructions.

If for any reason in the future you can no longer maintain your plugin, please consider transferring it to our unmaintained plugins repo. We can take ownership until another willing developer comes along.

Don't forget to join the official Homebridge Discord server, where plugin developers can get tips and advice from other developers and the Homebridge project team in the #plugin-development channel!

As a verified plugin, you can request a channel in the Discord server to discuss your plugin with users and other developers. Just ask in the #plugin-development channel.

Thank you for your contribution to the Homebridge community.

bwp91 commented 1 week ago

thanks for making that change!