homebridge / verified

Plugins Verified by Homebridge
https://homebridge.io/w/Verified-Plugins
GNU General Public License v3.0
366 stars 17 forks source link

Verification Request: homebridge-kasa-python #746

Open ZeliardM opened 1 month ago

ZeliardM commented 1 month ago

Plugin Name

homebridge-kasa-python

Link To GitHub Repo

https://github.com/ZeliardM/homebridge-kasa-python

Plugin Icon (Optional)

icon

The plugin does not offer the same nor less functionality than that of any existing verified plugin.

🟠 No (please explain in the more information box at the end)

The plugin successfully installs and does not start unless it is configured.

🟒 Yes

The plugin does not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.

🟒 Yes

The plugin does not contain any analytics or calls that enable you to track the user.

🟒 Yes

If the plugin needs to write files to disk (cache, keys, etc.), it stores them inside the Homebridge storage directory.

🟒 Yes

The plugin does not throw unhandled exceptions, the plugin must catch and log its own errors.

🟒 Yes

More Information

There is an existing verified plug-in: https://github.com/plasticrake/homebridge-tplink-smarthome This plug-in has not been updated in 6 months and api have not been updated in 9 months. Several outstanding issues and user reported errors without fixes. My plug-in uses a new python api that Home Assistant has just moved to for use and while I do not have the functionality of the api integrated yet, I am working on it. I would also like to have a channel created on the discord server for user discussion if needed, I'm on discord a lot.

github-actions[bot] commented 1 month ago

πŸ”΄ The following pre-checks failed:


🟒 The following pre-checks passed:


⚠️ Please action these failures and then comment /check to run the checks again. Let us know if you need any help.

If updating your package.json and config.schema.json files, don't forget to publish a new version to NPM.

ZeliardM commented 1 month ago

I think your checks for verification need to be updated.

I am using the latest template with engines defined as: "engines": { "node": "^18.20.4 || ^20.16.0 || ^22.6.0", "homebridge": "^1.8.0 || ^2.0.0-beta.0", "python": "^3.9.0" }, The pre-check says it fails because of node 18 and 20, which it does support, and homebridge 1.7.0 which is not listed in the latest plug-in template.

Please advise.

mkz212 commented 1 month ago

https://github.com/homebridge/verified/blob/latest/precheck/workspace/index.ts

From line 163. I think it's like you say. Now it is that it must be compatible with homebridge 1.7.0 but it should be 1.8.0. Also node should be changed from 18.20.1 to 18.20.4 and from 20.12.0 to 20.16.0 .

ZeliardM commented 1 month ago

I think that it should also be updated to include node 22 and Homebridge 2.0 as well since those are now in the templates as well.

mkz212 commented 1 month ago

@ZeliardM

This script checks whether your plugin supports the required versions. Node 22 is not required because the official version is from October 2024.

I did PR with fixes for this.

ZeliardM commented 1 month ago

@mkz212 gotcha, thanks!

bwp91 commented 1 month ago

/check

github-actions[bot] commented 1 month ago

🟒 The following checks passed:


πŸŽ‰ All checks passed successfully, nice work! Your plugin and/or icon will now be manually reviewed by the Homebridge team.

mkz212 commented 1 month ago

@ZeliardM Congratulations on passing the exam πŸ˜€πŸŽ‰

ZeliardM commented 1 month ago

@mkz212 @bwp91 thank you both! I appreciate it and really enjoy this community!