search

homebysix / pre-commit-macadmin

Pre-commit hooks for Mac admins.
63 stars 14 forks source link

Would be helpful to have number of errors in output and/or summary #60

Open jgstew opened 2 years ago

jgstew commented 2 years ago

THIS IS MY BAD, I MISSED AN ERROR!

I am triggering this precommit here: https://github.com/jgstew/NickETH-recipes/blob/160889bcd448cada2a0127a76431f7bdd5795fdb/.pre-commit-config.yaml#L7-L13

and yet it seems to be failing with exit code 1 even though all items are WARNINGS: https://github.com/jgstew/NickETH-recipes/runs/6026225280?check_suite_focus=true

Output:

/opt/hostedtoolcache/Python/3.10.4/x64/bin/pre-commit run --show-diff-on-failure --color=always --all-files
[INFO] Initializing environment for https://github.com/homebysix/pre-commit-macadmin.
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/adrienverge/yamllint.git.
[INFO] Installing environment for https://github.com/homebysix/pre-commit-macadmin.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/adrienverge/yamllint.git.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
Check AutoPkg Recipe List............................(no files to check)Skipped
Check AutoPkg Recipes....................................................Failed
- hook id: check-autopkg-recipes
- exit code: 1

Adobe/AdobeAIR-Win.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
AdoptOpenJDK/AdoptOpenJDK11JRE-Win[64](https://github.com/jgstew/NickETH-recipes/runs/6026225280?check_suite_focus=true#step:4:64).build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Microsoft/MicrosoftEdge-Win64.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
MiKTeX/MiKTeX-Win64.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Google/GoogleChrome-Win64.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Microsoft/DotNetCoreDesktopRuntime-Win64.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Fujitsu/FujitsuDeskUpdate-Win.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Serif/AffinityPhoto-Win64.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Microsoft/MicrosoftWebView2EvergreenBootstrapper-Win64.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Mozilla/Thunderbird-Win64.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Prusa/PrusaSlicerStandalone-Win.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
CrystalMaker/CrystalMaker-Win64.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
NXLog/NXLog-CE-Win64.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
NotepadPlusPlus/NotepadPlusPlus-Win64.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Adoptium/AdoptiumIcedTeaWeb-Win64.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Filemaker/FileMaker16Updater-Win64.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
TexStudio/TexStudio-Win64.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
PuTTY/PuTTY-Win64.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Apple/iTunes-Win64.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Tenable/Nessus-Agent-Win64.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
GIMP/GIMP-Win64.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Mozilla/Thunderbird-Win.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Github/GithubDesktop-Win64.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Adoptium/AdoptiumOpenJDKMSI-Win.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Microsoft/Teams-Win64.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Adobe/AdobeReaderDC-Win.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Adoptium/AdoptiumOpenJRE11-Win64.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Apple/iTunes-Win.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Keepass/Keepass-LANG.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Serif/AffinityPublisher-Win64.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
RStudio/RStudio-Win64.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
R/R-Win64.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Adoptium/AdoptiumIcedTeaWeb-Win64.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Keepass/Keepass-MSI.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
SEH/UTN_Manager-Win.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Jabref/Jabref-Win.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Mendeley/Mendeley-Desktop-Win.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Google/GoogleChromeMSI-Win.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Adobe/AdobeFlashPlayerPG-Win.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Github/Git-Win64.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Keepass/Keepass-Win.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
OBS/OBS-Studio-Win64.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
AmazonCorettoJDK8/AmazonCorettoJDK8MSI-Win.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Mozilla/Firefox-Win.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Citrix/Citrix-Workspace-Win.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Python/Python-Win64.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Bitwarden/BitwardenDesktop-Win64.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Slack/Slack-MSI.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Serif/AffinityDesigner-Win64.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Inkscape/Inkscape-Win.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
MiKTeX/MiKTeX-Win64.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
AmazonCorettoJDK8/AmazonCorettoJDK8-Win64.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Google/GoogleSyncMSI-Win64.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Microsoft/MicrosoftPowerToys-Win64.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Netop/NetopVisionPro-Win.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
XnView/XnView-Win.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Netop/NetopVisionPro-Win64.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Element/Element-Win64.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Lenovo/ThinkpadSystemUpdate-Win.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
NotepadPlusPlus/NotepadPlusPlus-Win64.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
NotepadPlusPlus/NotepadPlusPlus-Win64.build.recipe: Contains a download processor, but no EndOfCheckPhase processor.
Adoptium/AdoptiumOpenJDK8-Win64.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
NXLog/NXLog-CE-Win64.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Adobe/AdobeFlashPlayerAX-Win.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Filemaker/FileMaker19Updater-Win64.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Mersive/SolsticeClient-Win64.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
VLC/VLC-Win64.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Enpass/Enpass-Win.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Microsoft/DotNetDesktopRuntime-Win64.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Adobe/AdobeAIR-Win.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Dropbox/DropboxClient-Win.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
IBM/SpectrumProtect-Win64.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
LibreOffice/LibreOffice-Win.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
AutoPkgWin/AutoPkg-Win.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
WinMerge/WinMerge-Win64.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
ImageJ/Fiji-Win64.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Adobe/AdobeReaderDCMSI-Win.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Enpass/Enpass-Win.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
FileZilla/FileZilla-Win64.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
VMware/VMwareVMRC-Win.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Adoptium/AdoptiumOpenJRE8-Win64.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
SEH/UTN_Manager-Win.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
7-Zip/7-Zip-MSI.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Mozilla/Firefox-Win64.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Adoptium/AdoptiumOpenJRE11-Win.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Adoptium/AdoptiumOpenJRE8-Win.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Adobe/AdobeFlashPlayerMSI-Win.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
ImageJ/Fiji-Win64.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
SafeExamBrowser/SafeExamBrowser-Win.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Microsoft/DotNetCoreDesktopRuntime-Win64.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Microsoft/MicrosoftWebView2Runtime-Win64.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Microsoft/DotNetDesktopRuntime-Win64.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
AdoptOpenJDK/AdoptOpenJDKMSI-Win.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Mersive/SolsticeClient-Win64.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Google/GoogleSync-Win64.build/zzTest_GoogleSyncMSI-Win64.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Adoptium/AdoptiumOpenJDK11-Win64.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Zoom/ZoomClient-Win64.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Mozilla/Thunderbird-Win.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Adoptium/AdoptiumOpenJDK11-Win.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Adoptium/AdoptiumOpenJDK8-Win.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Microsoft/Teams-Win64.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
AutoPkgWin/AutoPkg-Win.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Google/GoogleChrome-Win.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Macrobond/Macrobond-Win64.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Fujitsu/FujitsuDeskUpdate-Win.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Zoom/ZoomClient-Win.build.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
Prusa/PrusaSlicerStandalone-Win.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.
VMware/VMwareTools-Win.download.recipe: WARNING: Recommend converting from <!-- --> style comments to a Comment key.

Forbid AutoPkg Overrides.................................................Passed
Check Yaml...............................................................Passed
Check for added large files..............................................Passed
Check python ast.........................................................Passed
Check for case conflicts.................................................Passed
Check for merge conflicts................................................Passed
Fix requirements.txt.................................(no files to check)Skipped
Detect Private Key.......................................................Passed
yamllint.................................................................Passed
Error: The process '/opt/hostedtoolcache/Python/3.10.4/x64/bin/pre-commit' failed with exit code 1
jgstew commented 2 years ago

oh, this is my bad! I missed one!