search

homebysix / recipe-robot

A kick ass tool for creating AutoPkg recipes.
Apache License 2.0
300 stars 28 forks source link

Allow recipe duplication #109

Closed ygini closed 8 years ago

ygini commented 8 years ago

Hi

Lot of recipes are unmaintained nowadays and when we try to use Recipe Robot to make a new version we hit the following error:

[ERROR] Sorry, AutoPkg recipes already exist for this app, and I can't blend new recipes with existing recipes.

Here are my suggestions:
    - See if one of the above recipes meets your needs, either as-is or using an override.
    - Or write your own recipe using one of the above as the ParentRecipe.

This is annoying. Recipe Robot could make me win a lot of time here and in the end make me loose it because of duplication limitation.

The main idea behind this lock is good but we need a way to get over it.

erikng commented 8 years ago

And once the new recipe is written are you going to submit a PR, duplicate it in the autopkg recipe list or keep it internal only?

On Aug 10, 2016, at 6:27 AM, Yoann Gini notifications@github.com<mailto:notifications@github.com> wrote:

Hi

Lot of recipes are unmaintained nowadays and when we try to use Recipe Robot to make a new version we hit the following error:

[ERROR] Sorry, AutoPkg recipes already exist for this app, and I can't blend new recipes with existing recipes.

Here are my suggestions:

This is annoying. Recipe Robot could make me win a lot of time here and in the end make me loose it because of duplication limitation.

The main idea behind this lock is good but we need a way to get over it.

You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/homebysix/recipe-robot/issues/109, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFa_GM-qSgWn14uwgnLuXwbN38XZjPsrks5qedHDgaJpZM4JhJDH.

ygini commented 8 years ago

It depend.

If the existing one is still maintained but I’ve did things differently OR if the original one isn’t maintained and on an abandoned repo any more I will do a duplicate (and I will do it in any ways).

If the original one isn’t updated but still on a active repo I will do a PR.

erikng commented 8 years ago

Can you define isn't maintained/abandoned?

I just recently went through this and while one autopkg author was no longer maintaining the recipes actively, they were not abandoned - he gladly accepted PRs.

On Aug 10, 2016, at 8:38 AM, Yoann Gini notifications@github.com<mailto:notifications@github.com> wrote:

It depend.

If the existing one is still maintained but I've did things differently OR if the original one isn't maintained and on an abandoned repo any more I will do a duplicate (and I will do it in any ways).

If the original one isn't updated but still on a active repo I will do a PR.

You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/homebysix/recipe-robot/issues/109#issuecomment-238906975, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFa_GAEn9seFHS3wUtxYux0Om6ZDLj5Sks5qefBYgaJpZM4JhJDH.

homebysix commented 8 years ago

Hi @ygini - It's intentionally undocumented, but there is a way to get around the "recipe already exists" obstacle:

I don't want to encourage people to upload recipes that duplicate the behavior of recipes that have already been written and publicly shared, but --ignore-existing does come in useful for auditing existing recipes (PDF page 42) or creating child recipes based on existing parents (PDF page 54).

Hope that answers your question!

ygini commented 8 years ago

Hi

This is perfect for me