search

homebysix / recipe-robot

A kick ass tool for creating AutoPkg recipes.
Apache License 2.0
300 stars 28 forks source link

Developer value breaks MunkiAdmin when set as array #141

Closed HaniAlshikh closed 5 years ago

HaniAlshikh commented 5 years ago

I discovered recipe robot today and its amazing, thanks a lot.

But while playing with it i noticed, that my MunkiAdmin interface breaks every time i add a recipe made with the recipe robot script. broken working

Adding it however from other source works fine, so i did some diffing and found that the only difference was the Developer key value, which in my case was an array and in the working recipe case was a string diff

i made the recipe using this command recipe-robot --ignore-existing https://github.com/homebysix/recipe-robot

and used this" recipe for compression https://github.com/autopkg/homebysix-recipes/blob/master/Recipe%20Robot/Recipe%20Robot.munki.recipe

homebysix commented 5 years ago

Hi @HaniAlshikh - Thanks for reporting this issue! The developer value should indeed be a string. However I can't reproduce the issue on my Mac on v1.1.0, even using the exact command you used.

I'm going to try a few more test recipes to see whether I can make it happen.

homebysix commented 5 years ago

Found it! Turns out the issue only occurs when the new StripDeveloperSuffixes preference is absent or False. The fix is queued up for version 1.1.1, which I'll try to get out soon. Thanks!

HaniAlshikh commented 5 years ago

Great, and thank you for the hard work