search

homebysix / recipe-robot

A kick ass tool for creating AutoPkg recipes.
Apache License 2.0
300 stars 28 forks source link

Remove white spaces when naming the recipes and folders #145

Open HaniAlshikh opened 5 years ago

HaniAlshikh commented 5 years ago

Can you please remove the white spaces or give us the option when generating apps that contain white spaces in their names like Backup and Sync from Google for example.

recipe-robot https://dl.google.com/drive/InstallBackupAndSync.dmg

thanks a lot.

homebysix commented 5 years ago

Hi @HaniAlshikh - I'm open to adding this feature, however I have a couple questions:

Thank you.

HaniAlshikh commented 5 years ago

Hi @homebysix

Are you asking for the ability to remove the space in recipe filenames only, or also in the filenames of the recipe's products (e.g. package produced by pkg recipes)?

it will be awesome to remove them everywhere if the user wants to or maybe also give the ability to substitute them with - or _

Is this request cosmetic only, or is there some actual problem being caused by the spaces in filenames?

off course not, i don't remember, what exactly my problem was, but i was automating some processes with AutoPKG and i had to remove the white spaces otherways it won't work. If you want i can dig into my work again and see what was my problem exactly but in general, i would say, it's better for scripting and automation when the white spaces are gone.

I won't say it's argent and i was able to find a way around the problem, so feel free to take care of other important issues. I was planning to fix this myself and contribute to this awesome project but it will take some time to do that :).

swy commented 4 years ago

I think I can point out a problem caused by spaces in filenames: Quicken offers "QuickBooks" (basically just an Electron app for interacting with the hosted online service) and "QuickBooks 2020" (manages a local data store, old school style). If one tries to use Recipe Robot on QuickBooks 2020, Recipe Robot declare that QuickBooks already exists- it appears to be stopping the comparison on the space, and coming to a inaccurate conclusion.