search

homebysix / recipe-robot

A kick ass tool for creating AutoPkg recipes.
Apache License 2.0
300 stars 28 forks source link

In 1.1.2 last sparkle item picked instead of latest #150

Closed andrewzirkel closed 3 years ago

andrewzirkel commented 5 years ago

Describe the bug In 1.1.2 when processing a sparkle feed with multiple items the last item in the feed is picked instead of the latest version. This results in an error if the last item is not available. In 1.1.1 the latest versioned item is picked.

To Reproduce Consider this feed: https://www.kutasoftware.com/updates/appcast_a1m.xml 1.1.2 downloads the last item in the feed instead of the latest version This failed since the last item is no longer available

Expected behavior The latest version should be downloaded if there is version information.

Desktop (please complete the following information):

homebysix commented 3 years ago

The Sparkle feed in this example is no longer active, however the core problem should have been addressed by this: https://github.com/homebysix/recipe-robot/commit/2767a34f9c930df1016030588e4bf1add9373cb0