search

homebysix / recipe-robot

A kick ass tool for creating AutoPkg recipes.
Apache License 2.0
300 stars 28 forks source link

Support for DMG inside a ZIP #189

Open n8felton opened 3 years ago

n8felton commented 3 years ago

I'm not sure if this is something that happens often (or why software vendors think it's necessary), but I have a ZIP download that contains a DMG.

To Reproduce

# ./recipe-robot -vv --keep-cache https://www.finaldraft.com/downloads/finaldraft1200b57Mac.zip
Processing: https://www.finaldraft.com/downloads/finaldraft1200b57Mac.zip
Input path looks like a download URL.
    Download URL is: https://www.finaldraft.com/downloads/finaldraft1200b57Mac.zip
Downloading file for further inspection...
    Download content-type is application/zip
################################################################################################################################# 100.0%
    Downloaded to /Users/n8felton/Library/Caches/Recipe Robot/2021-05-18_12-10-21_286621/finaldraft1200b57Mac.zip
Determining download format...
    File extension is zip
    Successfully unarchived zip
[ERROR] I wasn't able to gather enough information about this app to make recipes. If you saw any warnings above, they may contain more specific information.

# ls '/Users/n8felton/Library/Caches/Recipe Robot/2021-05-18_12-10-21_286621/unpacked'
Final Draft 12.dmg

Expected behavior Should Recipe Robot be attempting to find a DMG inside a ZIP?

homebysix commented 3 years ago

It's difficult to explain why a vendor would do this. The dmg is already compressed; wrapping it inside a zip adds no benefit at all.

Not a top priority, but I'll keep this issue open to consider.