homecineplexx / ioBroker.homepilot20

Rademacher Homepilot 2.0 (version >= 5.0.39)
MIT License
23 stars 7 forks source link

Adapter seems to be incompatible with JS-Controller 6.x #69

Open Wildbill-Z opened 2 weeks ago

Wildbill-Z commented 2 weeks ago

As seen here in iobroker forum, this adapter seems to have problems with JS-Controler 6.x.

mcm1957 commented 2 weeks ago

@mcm1957 just as reminder

mcm1957 commented 2 weeks ago

Adapter requires updates to be compatible with js-controller 6

host.iobroker
    2024-06-13 19:35:59.166 info    Restart adapter system.adapter.homepilot20.0 because enabled
host.iobroker
    2024-06-13 19:35:59.166 error   instance system.adapter.homepilot20.0 terminated with code 1 (JS_CONTROLLER_STOPPED)
host.iobroker
    2024-06-13 19:35:59.165 error   Caught by controller[0]: Node.js v20.14.0
host.iobroker
    2024-06-13 19:35:59.165 error   Caught by controller[0]: at node:internal/main/run_main_module:28:49
host.iobroker
    2024-06-13 19:35:59.165 error   Caught by controller[0]: at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:174:12)
host.iobroker
    2024-06-13 19:35:59.165 error   Caught by controller[0]: at Module._load (node:internal/modules/cjs/loader:1024:12)
host.iobroker
    2024-06-13 19:35:59.165 error   Caught by controller[0]: at Module.load (node:internal/modules/cjs/loader:1208:32)
host.iobroker
    2024-06-13 19:35:59.165 error   Caught by controller[0]: at Module._extensions..js (node:internal/modules/cjs/loader:1416:10)
host.iobroker
    2024-06-13 19:35:59.165 error   Caught by controller[0]: at Module._compile (node:internal/modules/cjs/loader:1358:14)
host.iobroker
    2024-06-13 19:35:59.164 error   Caught by controller[0]: at Object.<anonymous> (/opt/iobroker/node_modules/iobroker.homepilot20/main.js:2721:5)
host.iobroker
    2024-06-13 19:35:59.164 error   Caught by controller[0]: at startAdapter (/opt/iobroker/node_modules/iobroker.homepilot20/main.js:66:12)
host.iobroker
    2024-06-13 19:35:59.164 error   Caught by controller[0]: TypeError: utils.Adapter is not a constructor
host.iobroker
    2024-06-13 19:35:59.164 error   Caught by controller[0]: ^
host.iobroker
    2024-06-13 19:35:59.164 error   Caught by controller[0]: adapter = new utils.Adapter(options);
host.iobroker
    2024-06-13 19:35:59.163 error   Caught by controller[0]: /opt/iobroker/node_modules/iobroker.homepilot20/main.js:66
homecineplexx commented 2 weeks ago

thanks for this information but as i wrote in this ticket https://github.com/homecineplexx/ioBroker.homepilot20/issues/67 as i remember the js-controller is in beta status or? so i wait for a stable version

mcm1957 commented 2 weeks ago

Please do NOT wait. Time for adapter adaptions is now. The beta test phase is the time to fix incompatibilities and this is done by all active developers. Otherweise users will be frustrated when updateing js-controller and an outdated adapter does not work.

Is there any special reason to wait ?

If the adapter is known not to work with js-controller 6 at time of stable release it must be liste ats deprectaed / outdated at js-controller release notes.

I can provide a PR to fix the issues within the next week if this helps.