search

homedepot / github-webhook-resource

Concourse resource for remotely managing GitHub webhooks
Apache License 2.0
12 stars 20 forks source link

Add support for instanced pipelines. #29

Closed dumptruckman closed 2 years ago

dumptruckman commented 2 years ago

Change Request

Tell us about your environment

Describe your change request

The problem you want to solve: For pipelines using instances variables (instanced pipelines), this resource does not set up working webhooks. You need to append query params for each instance variable in the form of &var.some-var="someval".

Your take on the correct solution to problem: Ideally the resource will automatically populate all instance variables in this way. An alternative is having a vars attribute that can be manually populated in the pipeline script; however, if any vars are forgotten in this manual way then I don't think the webhook will work.

Do you plan to submit a pull request to implement this change? I may try if I can find the time to do so.

jduv commented 2 years ago

+1, this would help us greatly.

GavinFigueroa commented 2 years ago

Resolved in #30