homedepot / github-webhook-resource

Concourse resource for remotely managing GitHub webhooks
Apache License 2.0
12 stars 20 forks source link

Support pipeline name as param #43

Closed jakul closed 1 year ago

jakul commented 1 year ago

What is the purpose of this pull request?

Addresses #36

What changes did you make? (Give a brief overview) Add the capability to specify pipeline name and pipeline instance vars. This allows one pipeline to configure the webhooks for another one, which is useful when using multi-branch workflows, in which one pipeline is responsible for creating and destroying other pipelines.

Without this change there is no easy way for the parent pipeline to set the webhook in Github to trigger the child pipelines, nor to delete that webhook once the child pipeline is removed.

Is there anything specific you would like reviewers to focus on? No

jakul commented 1 year ago

@GavinFigueroa @billimek FYI

GavinFigueroa commented 1 year ago

Thanks for your patience. This looked good to me too.