search

homeeondemand / react-native-mapbox-navigation

A navigation UI ready to drop into your React Native application
MIT License
160 stars 122 forks source link

Expo EAS #112

Open craigmulligan opened 1 year ago

craigmulligan commented 1 year ago

Has anyone had a go at packaging this with expo's new EAS build system? I'm planning on working on it but checking if anyone has got it working before.

As far as I can tell it requires writing a expo plugin that writes the manifest files for each platform at build time. You can see an example of bluetooth here: https://github.com/expo/config-plugins/tree/main/packages/react-native-ble-plx

mckeny3 commented 1 year ago

did you manage to get it done?

craigmulligan commented 1 year ago

I haven't yet. But I do still plan on working on it. Will update that issue when I get around to it.

zivc commented 1 year ago

Any updates @craigmulligan? I await your feedback with baited breath :S

craigmulligan commented 1 year ago

Just a small update, I had a quick look and it appears the nmapbox packages plugin does everything we need for android, so just installing it along with this package works fine, the problem now is that react-native-mapbox-navigation uses and older version of gradle than the expo build system so it's failing to build because of deprecations in gradle 7 so trying to figure that out atm.

ismael-su commented 1 year ago

@craigmulligan i'm going through the same issue regarding old gradle version, have you managed to make it work ?

craigmulligan commented 1 year ago

No haven't looked at it again. I still hope to at some point.

JKKholmatov commented 1 year ago

Any updates?

ismael-su commented 1 year ago

Any updates?

Am working on a workaround. Works with native module on Android but eventually crashes when route tiles render. By not showing the route tiles it works I will soon publish the npm package

mckeny3 commented 1 year ago

yep...gave me headache...i had to switch to flutter...the mapbox navigation work there

santitopo commented 11 months ago

Any updates?

Am working on a workaround. Works with native module on Android but eventually crashes when route tiles render. By not showing the route tiles it works I will soon publish the npm package

Hey @ismael-su ! I'm trying to implement an Expo Module myself to use the latest versions of the iOS and Android Mapbox Navigation sdks (so basically skipping this library which seems unmantained), and I came across your comment.

I currently have it working in iOS but in Android it crashes as soon as the map attempts to render. Im trying to instantiate a very basic NavigationView (btw, the same code does work in a native Android project).

Can you tell me more about how you solved it if you happen to do it? and also how can I disable the tiles so I can see if at least that gets me through instantiating the view.

Thanks in advance!

KindCoder-no commented 7 months ago

Did anyone manage to get it working with expo eas?

ismael-su commented 7 months ago

@santitopo hello, just realized you mentionned me, i stopped working on the project months ago because i wasn't even able to reproduce the working build. am still waiting

cmaycumber commented 1 month ago

I'm thinking about creating an expo-plugin. Wondering if I need to use the forked library from #116 or if this is the repo I should attempt to do it on.

Does anyone have feedback on what library they're currently using?