search

homeeondemand / react-native-mapbox-navigation

A navigation UI ready to drop into your React Native application
MIT License
162 stars 123 forks source link

Is this still maintained? #64

Closed zoolle closed 2 years ago

zoolle commented 2 years ago

I can see that there is MapBox Navigation SDK 2.0 but I haven't seen an update of this project for couple of months is someone still working on it?

JorgeQuevedoC commented 2 years ago

I think it is a great question and is important to know for some projects that are in progress

joe307bad commented 2 years ago

This project is still used in production, just not in active development. Pull requests are welcome. We are trying to dedicate time to the active development of this library and will hopefully have some progress in the coming months.

haizenburg commented 2 years ago

Hi @joe307bad who do i talk to if i wish to contribute?

joe307bad commented 2 years ago

Hey @haizenburg, thanks for reaching out. I am the point of contact for contributing to this repo. Please feel free to open a PR and I'd be happy to review and merge ☺️

JorgeQuevedoC commented 2 years ago

Hey @joe307bad, I will try to add a couple of props that might be helpful for everyone else. My question is how do you guys test your implementation before making the PR?

joe307bad commented 2 years ago

Hey @JorgeQuevedoC, thats a good question. I would say that any PR would probably benefit from also adding an example app to this project? That seems like the best way to test any changes. If someone were to put up a pull request I would be happy to make some time to also a minimal example project.

JorgeQuevedoC commented 2 years ago

Hi @joe307bad I have done some changes but I don't know how to test them on my project before I create the PR. Any suggestion?

And beside my changes I would like to help to migrate the library to use "Mapbox Navigation 2.0.0" since there are a lot of bugs that have been fixed

joe307bad commented 2 years ago

Hey @JorgeQuevedoC, thanks for taking the time to work on this, I really appreciate it.

I would say the best way to test is to add an /example directory to the root of this repo and use npx react-native init to add an example application. Once the example app is created, we can create a basic implementation of react-native-mapbox-navigation within this repo. I have seen other packages do this and I think its probably the best practice, what do you think think?

Also, I wouldn't worry about testing your changes before posting the PR. Feel free to post the PR without an example app and I would be happy to work with you to figure out the best way to test.

JorgeQuevedoC commented 2 years ago

@joe307bad would you mind having a call to ask you a couple of thing about it?

joe307bad commented 2 years ago

Hey @JorgeQuevedoC, I would be more than happy to have a call but lets exhaust some options before we try to coordinate a phone call. Could you post your PR and allow me to take a look? Do you have a specific error you may be running into?

JorgeQuevedoC commented 2 years ago

@joe307bad There are no errors because I don't know how to run the changes locally to see if it works

joe307bad commented 2 years ago

Thanks @JorgeQuevedoC, feel free to post a PR (even if the code is a work in progress) and we can communicate about any new code within that PR. I would be happy to coordinate a call when I can look at some code and formulate a strategy for testing the changes you would like to make 😄