Upgrading dependencies, webpack config and adding GitHub Actions

homerchen19 / github-file-icons

🌈 🗂 A browser extension which gives different filetypes different icons to GitHub, GitLab, gitea and gogs.

https://chrome.google.com/webstore/detail/file-icon-for-github-and/ficfmibkjjnpogdcfhfokmihanoldbfe

MIT License

1.41k stars 67 forks source link

Upgrading dependencies, webpack config and adding GitHub Actions #116

Closed Harmelodic closed 2 years ago

Harmelodic commented 2 years ago

Summary of changes:

General updates to bring all packages up to date.
Switching to use webpack-ext-reloader instead of webpack-extension-reloader because the former is compatible with Webpack 5, where as the other is not.
Removed unavailable webpack flags --display-error-details and --colors and replaced them with the respective stats options in the production config, defined in webpack.config.js.
Added GitHub Actions to provide validation in future pull-requests (as well as a master branch build that you could extend to auto publish to the Chrome Webstore).

Any questions just ask, but I tested npm run zip and npm start and both seem to work fine.

homerchen19 commented 2 years ago

Thanks for upgrading dependencies. I think we don't need package-lock.json because I used yarn at the beginning. Having another lock file is a bit unnecessary. Could you remove it?

Harmelodic commented 2 years ago

Thanks for upgrading dependencies. I think we don't need package-lock.json because I used yarn at the beginning. Having another lock file is a bit unnecessary. Could you remove it?

Done! 👍

Harmelodic commented 2 years ago

Thanks for upgrading dependencies. I think we don't need package-lock.json because I used yarn at the beginning. Having another lock file is a bit unnecessary. Could you remove it?

I've also now changed the Actions to use yarn commands, since you want to use yarn 😄

Harmelodic commented 2 years ago

Done with my changes, by the way 😅