File icons in pull requests and commit screens

homerchen19 / github-file-icons

🌈 🗂 A browser extension which gives different filetypes different icons to GitHub, GitLab, gitea and gogs.

https://chrome.google.com/webstore/detail/file-icon-for-github-and/ficfmibkjjnpogdcfhfokmihanoldbfe

MIT License

1.41k stars 67 forks source link

File icons in pull requests and commit screens #118

Closed crazyoptimist closed 2 years ago

crazyoptimist commented 2 years ago

Thank you for your great work! Hope you can add terraform file icons as well. Cheers!

crazyoptimist commented 2 years ago

Oh that's weird, it's already supported, never mind.

But in the improved github UI(improved pull request/commit screen, see the attached image), it doesn't show up icons at all for any kind of files.

homerchen19 commented 2 years ago

It works on my Chrome.

Are you using Firefox? If so, it may be caused by https://github.com/homerchen19/github-file-icons/issues/117. I just fixed it, could you try again later?

crazyoptimist commented 2 years ago

I use the latest version of chrome, and that's weird. I removed the extension and reinstalled, but it still persists:

And it works in other places:

homerchen19 commented 2 years ago

hmm could you provide the URL of that PR? I can check if it works on my side.

crazyoptimist commented 2 years ago

https://github.com/crazyoptimist/terraform-basecamp/pull/1

homerchen19 commented 2 years ago

Well it works on my Chrome. Maybe you can turn off other extensions just in case there are some conflicts?

crazyoptimist commented 2 years ago

Oh that's super weird. I disabled adblocker extension(the only one I'm using except for yours) and tried again, but the same thing happens. Anyways, if it's only me, can close this issue. Never mind. Thanks!