search

homerchen19 / github-file-icons

🌈 🗂 A browser extension which gives different filetypes different icons to GitHub, GitLab, gitea and gogs.
https://chrome.google.com/webstore/detail/file-icon-for-github-and/ficfmibkjjnpogdcfhfokmihanoldbfe
MIT License
1.43k stars 68 forks source link

Folder icon is changed #12

Closed koddsson closed 6 years ago

koddsson commented 6 years ago

Not sure if this is by design but some folders have their icon switched out like this:

image

To me, the .github/ folder in the screenshot should still have the folder icon but I could be alone in that opinion. Would you accept a PR to make sure we don't change the folder icons or at least provide the option to change the behaviour for people that would like to keep the folder icons intact?

homerchen19 commented 6 years ago

Yes, some icons of folder with specific name will be changed. I used file-icons-js to determine the icon by the its name, and I didn't identify whether the name is a file or a folder. It's okay to not change the folder icons! PRs are welcome.

koddsson commented 6 years ago

Hey @xxhomey19. I was going to take a stab at this but I can't get the extension running locally. It's just a matter of checking out the code, running npm install && npm run build and loading the build/ folder as a unpackaged extension in chrome, right?

homerchen19 commented 6 years ago

Yes, that’s right. Doesn’t it work?

MichielDx commented 6 years ago

Doesn't work for me either after the pjax merge

homerchen19 commented 6 years ago

😕 That’s strange. Does it show any error message? Btw, my node version is 9.2.1.

koddsson commented 6 years ago

It happened kind of sparatically for me. Just when building and loading the extension unpacked tho. I disabled some other github extensions and it worked a bit better but I'm not sure what that was.