homerchen19 / github-file-icons

🌈 🗂 A browser extension which gives different filetypes different icons to GitHub, GitLab, gitea and gogs.
https://chrome.google.com/webstore/detail/file-icon-for-github-and/ficfmibkjjnpogdcfhfokmihanoldbfe
MIT License
1.43k stars 69 forks source link

Icon package file-icons-js is very outdated #120

Closed csandman closed 2 years ago

csandman commented 2 years ago

The package file-icons-js which supplies all of the icons for this package hasn't been updated in a long time, and is missing a lot of the specific file name icons that are currently offered by the file-icons/atom package. Here is an example of what it looks like with this package:

image

And here is an example using a fork I made which pulls in the newest icons from Atom's file-icons:

image

As you can see, it's missing:

And there are many others it is missing for other languages.

I have a local fork I've been working on which has a script to pull in the newest icon fonts and icon database file, and essentially replicates the way file-icons-js works except local to the project. If you'd consider going down that route, I'll make a PR but I want to gauge interest first.

homerchen19 commented 2 years ago

wow it looks much nicer! I totally agree file-icons-js is very outdated. Please feel free to send a PR to fix it

csandman commented 2 years ago

Just submitted a PR! Feel free to request any changes, or change anything yourself. I actually made these changes a few months ago, and I've been running a local build for a while, but I forgot to mention them until now haha.

shuuji3 commented 2 years ago

Thank you, Chris! This is a great update.🙂