search

homerchen19 / github-file-icons

🌈 🗂 A browser extension which gives different filetypes different icons to GitHub, GitLab, gitea and gogs.
https://chrome.google.com/webstore/detail/file-icon-for-github-and/ficfmibkjjnpogdcfhfokmihanoldbfe
MIT License
1.45k stars 70 forks source link

Modify `update-assets` script to remove invalid regex for Safari #124

Closed csandman closed 2 years ago

csandman commented 2 years ago

This PR will close #123, it changes the update-assets.mjs script to modify the icon-db after downloading it. It replaces any positive lookaround in the file's RegEx expressions (which are not allowed in Safari (or Firefox)) with their content. This should prevent any future issues from cropping up as well.

Here's an example of the Regex, showing the part that is not allowed: https://regexr.com/6oovg

csandman commented 2 years ago

@christopherpickering Thanks haha, I have a weird fondness for RegEx.