search

homerchen19 / github-file-icons

🌈 🗂 A browser extension which gives different filetypes different icons to GitHub, GitLab, gitea and gogs.
https://chrome.google.com/webstore/detail/file-icon-for-github-and/ficfmibkjjnpogdcfhfokmihanoldbfe
MIT License
1.45k stars 70 forks source link

Remove all local file-icon content in favor of npm package #151

Closed csandman closed 1 year ago

csandman commented 1 year ago

Well, it's been over a year but I finally revisited my PR #121! I ended up making a new package to replace the need for the internal script I originally submitted to this project. You can check it out here: https://github.com/csandman/atom-file-icons! Originally I mentioned...

I have started looking into this, and I will probably do it at some point. My main thing is, if I'm going to do it, I'd like to make sure I have an action set up to automatically update the package, otherwise I'd probably end up forgetting about it at some point and letting it get just as outdated as file-icons-js.

I had actually written a version of the package soon after I submitted the code to your extension, but I never got around to automating the update publishing. I finally went for it last night, as I've been considering using this package for a project of my own. You can check out my action for that here: https://github.com/csandman/atom-file-icons/blob/main/.github/workflows/update-from-upstream.yml

It just runs the script to pull the updated assets from the original package, and if there are any changes, it will build the project, publish to npm, and publish a version to GitHub.

Also, I tested and everything is working the same:

image