Temporary .txt and .pdf fix

homerchen19 / github-file-icons

🌈 🗂 A browser extension which gives different filetypes different icons to GitHub, GitLab, gitea and gogs.

https://chrome.google.com/webstore/detail/file-icon-for-github-and/ficfmibkjjnpogdcfhfokmihanoldbfe

MIT License

1.41k stars 67 forks source link

Temporary .txt and .pdf fix #152

Open Morphclue opened 9 months ago

Morphclue commented 9 months ago

Description

Unfortunately, I have not been able to locate the exact source of the error. However, I have temporarily fixed two icons which were addressed in Issues #126 and #128. To remember that this is a temporary solution this was documented in icons.css.

During development I've noticed that the .idea folder was not yet excluded for development with a JetBrains IDE. This folder is now excluded in the .gitignore.

XxOsirisxX77 commented 4 months ago

The reason PDF icons doesn't show up, is because it doesn't exists in atom-file-icons library (https://github.com/csandman/atom-file-icons/blob/main/src/css/icons.css). They have it registered in theirs icons "database" (https://github.com/csandman/atom-file-icons/blob/2cafbb420f62a36a7774337c806c578736c41b4c/src/db/icondb.js#L1521) but it just won't spawn any icon because of this.

homerchen19 commented 4 months ago

Yes I hope we can fix the issue there