homerchen19 / github-file-icons

🌈 🗂 A browser extension which gives different filetypes different icons to GitHub, GitLab, gitea and gogs.
https://chrome.google.com/webstore/detail/file-icon-for-github-and/ficfmibkjjnpogdcfhfokmihanoldbfe
MIT License
1.43k stars 68 forks source link

Support GitHub mobile layout #29

Closed arnellebalane closed 6 years ago

arnellebalane commented 6 years ago

Resolves #23

Hello, thanks for this really awesome extension! Here's my attempt to implement support for GitHub mobile layout.

Here are screenshots of the update for both in Firefox on Android and in Chrome using the mobile layout emulator in DevTools.

firefox chrome

homerchen19 commented 6 years ago

Thanks for your contribution! Nice work. However, I found a little weird thing after I checked out to this PR and ran it.

This is version 0.3.1 (latest version) kapture 2018-03-17 at 10 46 17

This is your PR kapture 2018-03-17 at 10 48 23

Icons will briefly flash when browser was going next page. I don't think it's good user experience, so could you fix it?

arnellebalane commented 6 years ago

I will work on fixing that. I will push updates soon.

arnellebalane commented 6 years ago

@xxhomey19 I've pushed a fix for the brief flash of the icons when navigating to the next page in this PR. Here's how it looks like now:

github-file-icon