search

homerchen19 / github-file-icons

🌈 🗂 A browser extension which gives different filetypes different icons to GitHub, GitLab, gitea and gogs.
https://chrome.google.com/webstore/detail/file-icon-for-github-and/ficfmibkjjnpogdcfhfokmihanoldbfe
MIT License
1.46k stars 70 forks source link

Better options page #32

Closed Jackymancs4 closed 6 years ago

Jackymancs4 commented 6 years ago

Hello @xxhomey19 Love the new feature. Here what I think is a little improvement.

I removed the open_in_tab that according to https://developer.chrome.com/extensions/optionsV2#step-1 is deprecated on Chrome, and in Firefox is simply very ugly. Then I cleaned up the options page layout, deleting the redundant title.

Before on Chrome After on Chrome
before - chrome - final after - chrome - final
Before on Firefox After on Firefox
before - firefox - final after - firefox - final

Note that the 'before' screens refer to the extension without open_in_tab

Tested on Firefox 59.0.1 and Chrome 65

homerchen19 commented 6 years ago

I'll publish this tomorrow. Thanks! 👍