search

homerchen19 / github-file-icons

🌈 🗂 A browser extension which gives different filetypes different icons to GitHub, GitLab, gitea and gogs.
https://chrome.google.com/webstore/detail/file-icon-for-github-and/ficfmibkjjnpogdcfhfokmihanoldbfe
MIT License
1.43k stars 68 forks source link

Icons are slightly offset on mobile #33

Closed RoiEXLab closed 6 years ago

RoiEXLab commented 6 years ago

Not a big deal, but I just noticed this: grafik Tested on Firefox for Android.

homerchen19 commented 6 years ago

This is definitely a bug 😕

arnellebalane commented 6 years ago

The misalignment of the file icons on GitHub is caused by the removal of the octicon class on the icon element, introduced in this commit: https://github.com/xxhomey19/github-file-icon/commit/8889ab564c579526a5ddb095c6d9e81ccddc70b7?diff=split#diff-58abb088be4b02338aacb69a0580ab7f

The octicon class absolutely-positions the icon element to the left.

homerchen19 commented 6 years ago

Hey @RoiEXLab I have uploaded a new version on Firefox. Should fix this issue.

arnellebalane commented 6 years ago

Can confirm that 0.4.2 has fixed the issue on Firefox for Android :100:

homerchen19 commented 6 years ago

Close due to no response, and it has been fixed.

RoiEXLab commented 6 years ago

@xxhomey19 Sorry for not responding 😅 I probably missed your comment back then. Thanks for fixing this 👍

homerchen19 commented 6 years ago

It's okay. 👍